Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 196823006: Replace nextSiblingChildren() with simpler nextSibling() when equivalent (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Replace nextSiblingChildren() with simpler nextSibling() when equivalent This makes the code more readable as it makes it clear we are only traversing children. This is also a bit more efficient as nextSiblingChildren() tries to traverse the ancestors siblings when done with the current siblings. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/html/HTMLCollection.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
PTAL
6 years, 9 months ago (2014-03-20 02:28:10 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-20 02:34:48 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-20 02:44:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/196823006/1
6 years, 9 months ago (2014-03-20 02:44:35 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 04:12:19 UTC) #5
Message was sent while issue was closed.
Change committed as 169614

Powered by Google App Engine
This is Rietveld 408576698