third_party/WebKit/Source/core/page/FrameTree.h - Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.h

Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/FrameTree.h

diff --git a/third_party/WebKit/Source/core/page/FrameTree.h b/third_party/WebKit/Source/core/page/FrameTree.h

index 2314a451403eb493881dd1b741c4d27b4f07d5fc..c241f8c571d3ee02e9b2acb6c610591172eed869 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.h

+++ b/third_party/WebKit/Source/core/page/FrameTree.h

@@ -82,6 +82,8 @@ private:

const AtomicString& name,

const AtomicString& fallbackName = nullAtom) const;

bool uniqueNameExists(const AtomicString& name) const;

+ AtomicString ensureUniquenessOfUniqueName(const AtomicString& potentiallyUniqueName) const;

+ void setUniqueName(const AtomicString&);

Member<Frame> m_thisFrame;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/FrameTree.cpp » ('j') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('J')