third_party/WebKit/LayoutTests/fast/frames/unique-name-remove-add-child.html - Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/unique-name-remove-add-child.html

Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments from dcheng@. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/unique-name-main-frame-conflict-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/frames/unique-name-remove-add-child-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 function runTest()

	6 {

	7 if (window.testRunner) {

	8 testRunner.dumpAsText();

	9 testRunner.dumpChildFramesAsText();

	10 }

	11 body = document.getElementById('body');

	12 frame1 = document.getElementById('frame1');

	13 body.removeChild(frame1);

	14

	15 // frame3 is added to the frame tree when the parent has the same number of

	16 // children as when frame2 was being added. In the past this has led to

	17 // frame2 and frame3 having the same unique name - https://crbug.com/576969# c3

	18 frame3 = document.createElement('iframe');

	19 frame3.id = "frame3";

	20 body.appendChild(frame3);

	21 }

	22 </script>

	23 </head>

	24 <body onload="runTest()" id="body">

	25 <iframe id="frame1"></iframe>

	26 <iframe id="frame2"></iframe>

	27 </body>

	28 </html>

OLD	NEW