third_party/WebKit/LayoutTests/fast/frames/unique-name-main-frame-conflict.html - Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/unique-name-main-frame-conflict.html

Issue 1968213002: Try harder to make sure that blink::FrameTree::m_uniqueName is truly unique. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments from dcheng@. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/unique-name-ancestor-concatenation-conflict-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/frames/unique-name-main-frame-conflict-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 function runTest()

	6 {

	7 if (window.testRunner) {

	8 testRunner.dumpAsText();

	9 testRunner.dumpChildFramesAsText();

	10 }

	11 // Before https://crrev.com/1968213002 main frame's unique name would be

	12 // set without any checks for conflicts with names of subframes.

	13 //

	14 // Note that layout tests do not include the name of the main frame

	15 // in test output - this means that the test verification of uniqueness

	16 // depends on the assert in FrameTree::setUniqueName (which should make

	17 // this test crash if the main frame's unique name is not truly unique).

	18 window.name = "subframeName";

	19 }

	20 </script>

	21 </head>

	22 <body onload="runTest()">

	23 <iframe name="subframeName"></iframe>

	24 </body>

	25 </html>

OLD	NEW