Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1968193002: avoid spread args (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
vsm, Leaf, sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -24 lines) Patch
M lib/runtime/dart_sdk.js View 11 chunks +15 lines, -15 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 2 chunks +13 lines, -3 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/generators.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
here's another tweak that might help perf
4 years, 7 months ago (2016-05-11 20:10:38 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-11 20:15:45 UTC) #3
sra1
lgtm
4 years, 7 months ago (2016-05-11 20:33:07 UTC) #4
Jennifer Messerly
4 years, 7 months ago (2016-05-11 20:44:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5de622ebf58ab870c3ed3c63ffa4b34d2e0bb6fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698