Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1968143002: Small fix in Scanner (Closed)

Created:
4 years, 7 months ago by hausner
Modified:
4 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Small fix in Scanner Use intptr_t instead of TokenPosition to denote the index of a token in the token stream. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/444665465c057448649d84ac0a21ad17dac95915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/scanner.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/scanner.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 7 months ago (2016-05-11 17:34:11 UTC) #3
Cutch
lgtm
4 years, 7 months ago (2016-05-11 17:35:47 UTC) #4
hausner
4 years, 7 months ago (2016-05-11 17:49:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
444665465c057448649d84ac0a21ad17dac95915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698