Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

Issue 1968083004: Implement the private API for quick unlock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d1c2746567b0af50e0766d60a70c71f35ba97015
--- /dev/null
+++ b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
@@ -0,0 +1,220 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h"
+
+#include "chrome/browser/chromeos/login/quick_unlock/pin_storage.h"
+#include "chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
+#include "chromeos/login/auth/extended_authenticator.h"
+#include "chromeos/login/auth/user_context.h"
+#include "extensions/browser/event_router.h"
+
+namespace quick_unlock_private = extensions::api::quick_unlock_private;
+namespace SetModes = quick_unlock_private::SetModes;
+namespace GetActiveModes = quick_unlock_private::GetActiveModes;
+namespace GetAvailableModes = quick_unlock_private::GetAvailableModes;
+namespace OnActiveModesChanged = quick_unlock_private::OnActiveModesChanged;
+using QuickUnlockMode = quick_unlock_private::QuickUnlockMode;
+using ModeList = std::vector<QuickUnlockMode>;
+
+namespace extensions {
+
+namespace {
Devlin 2016/06/13 14:50:23 nitty nit: \n after this line
jdufault 2016/06/20 22:18:25 Done.
+const char kModesAndCredentialsLengthMismatch[] =
+ "|modes| and |credentials| must have the same number of elements";
+const char kMultipleModesNotSupported[] =
+ "Currently at most one quick unlock mode can be active.";
+
+QuickUnlockPrivateSetModesFunction::CreateAuthenticator g_create_authenticator =
+ nullptr;
+QuickUnlockPrivateSetModesFunction::ModesChangedEventHandler
+ g_modes_changed_handler = nullptr;
+
+// Triggers a QuickUnlockMode change event.
+void FireEvent(Profile* profile, const ModeList& modes) {
+ // Allow unit tests to override how events are raised/handled.
+ if (g_modes_changed_handler) {
+ g_modes_changed_handler(modes);
+ return;
+ }
+
+ std::unique_ptr<base::ListValue> args = OnActiveModesChanged::Create(modes);
+ std::unique_ptr<Event> event(
+ new Event(events::QUICK_UNLOCK_PRIVATE_ON_ACTIVE_MODES_CHANGED,
+ OnActiveModesChanged::kEventName, std::move(args)));
+ EventRouter::Get(profile)->BroadcastEvent(std::move(event));
+}
+
+// Returns the active set of quick unlock modes.
+ModeList GetActiveModes(Profile* profile) {
+ ModeList modes;
+
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile);
+ if (pin_storage->IsPinSet())
+ modes.push_back(quick_unlock_private::QUICK_UNLOCK_MODE_PIN);
+
+ return modes;
+}
+
+// Returns true if |a| and |b| contain the same elements. The elements do not
+// need to be in the same order.
+bool AreModesEqual(const ModeList& a, const ModeList& b) {
+ if (a.size() != b.size())
+ return false;
+
+ // This is a slow comparison algorithm, but the number of entries in |a| and
+ // |b| will always be very low (0-3 items) so it doesn't matter.
+ for (size_t i = 0; i < a.size(); ++i) {
+ if (std::find(b.begin(), b.end(), a[i]) == b.end())
+ return false;
+ }
+
+ return true;
+}
+
+} // namespace
+
+//////////// quickUnlockPrivate.getAvailableModes
+
+QuickUnlockPrivateGetAvailableModesFunction::
+ QuickUnlockPrivateGetAvailableModesFunction()
+ : chrome_details_(this) {}
+
+QuickUnlockPrivateGetAvailableModesFunction::
+ ~QuickUnlockPrivateGetAvailableModesFunction() {}
+
+ExtensionFunction::ResponseAction
+QuickUnlockPrivateGetAvailableModesFunction::Run() {
+ // TODO(jdufault): Check for policy and do not return PIN if policy makes it
+ // unavailable. See crbug.com/612271.
+ const ModeList modes = {quick_unlock_private::QUICK_UNLOCK_MODE_PIN};
+
+ return RespondNow(ArgumentList(GetAvailableModes::Results::Create(modes)));
+}
+
+//////////// quickUnlockPrivate.getActiveModes
+
+QuickUnlockPrivateGetActiveModesFunction::
+ QuickUnlockPrivateGetActiveModesFunction()
+ : chrome_details_(this) {}
+
+QuickUnlockPrivateGetActiveModesFunction::
+ ~QuickUnlockPrivateGetActiveModesFunction() {}
+
+ExtensionFunction::ResponseAction
+QuickUnlockPrivateGetActiveModesFunction::Run() {
+ const ModeList modes = GetActiveModes(chrome_details_.GetProfile());
+ return RespondNow(ArgumentList(GetActiveModes::Results::Create(modes)));
+}
+
+//////////// quickUnlockPrivate.setModes
+
+// static
+void QuickUnlockPrivateSetModesFunction::SetCreateAuthenticatorForTesting(
+ QuickUnlockPrivateSetModesFunction::CreateAuthenticator allocator) {
+ g_create_authenticator = allocator;
+}
+
+// static
+void QuickUnlockPrivateSetModesFunction::SetModesChangedEventHandlerForTesting(
+ ModesChangedEventHandler handler) {
+ g_modes_changed_handler = handler;
+}
+
+QuickUnlockPrivateSetModesFunction::QuickUnlockPrivateSetModesFunction()
+ : chrome_details_(this) {
+ // Setup a fake authenticator if we are testing.
+ if (g_create_authenticator)
+ extended_authenticator_ = g_create_authenticator(this);
+ else
+ extended_authenticator_ = chromeos::ExtendedAuthenticator::Create(this);
+}
+
+QuickUnlockPrivateSetModesFunction::~QuickUnlockPrivateSetModesFunction() {}
+
+ExtensionFunction::ResponseAction QuickUnlockPrivateSetModesFunction::Run() {
+ params_ = SetModes::Params::Create(*args_);
+ EXTENSION_FUNCTION_VALIDATE(params_.get());
+
+ if (params_->modes.size() != params_->credentials.size())
+ return RespondNow(Error(kModesAndCredentialsLengthMismatch));
+
+ if (params_->modes.size() > 1)
+ return RespondNow(Error(kMultipleModesNotSupported));
+
Devlin 2016/06/13 14:50:23 nit: if (params_->modes.empty()) return RespondN
jdufault 2016/06/20 22:18:25 This would break disabling quick unlock.
+ user_manager::User* user = chromeos::ProfileHelper::Get()->GetUserByProfile(
+ chrome_details_.GetProfile());
+ chromeos::UserContext user_context(user->GetAccountId());
+ user_context.SetKey(chromeos::Key(params_->account_password));
+
+ // The extension function needs to stay alive while the authenticator is
+ // running the password check. Add a ref before the authenticator starts, and
+ // remove the ref after it invokes one of the OnAuth* callbacks.
+ AddRef();
+
+ content::BrowserThread::PostTask(
+ content::BrowserThread::UI, FROM_HERE,
+ base::Bind(&chromeos::ExtendedAuthenticator::AuthenticateToCheck,
+ extended_authenticator_.get(), user_context, base::Closure()));
+
+ return RespondLater();
+}
+
+void QuickUnlockPrivateSetModesFunction::OnAuthFailure(
+ const chromeos::AuthFailure& error) {
+ Respond(ArgumentList(SetModes::Results::Create(false)));
+ Release(); // Balanced in Run().
+}
+
+void QuickUnlockPrivateSetModesFunction::OnAuthSuccess(
+ const chromeos::UserContext& user_context) {
+ const ModeList initial_modes = GetActiveModes(chrome_details_.GetProfile());
+ ApplyModeChange();
+ const ModeList updated_modes = GetActiveModes(chrome_details_.GetProfile());
+
+ if (!AreModesEqual(initial_modes, updated_modes))
+ FireEvent(chrome_details_.GetProfile(), updated_modes);
+
+ Respond(ArgumentList(SetModes::Results::Create(true)));
+ Release(); // Balanced in Run().
+}
+
+void QuickUnlockPrivateSetModesFunction::ApplyModeChange() {
+ // This function is setup so it is easy to add another quick unlock mode while
+ // following all of the invariants, which are:
+ //
+ // 1: If an unlock type is not specified, it should be deactivated.
+ // 2: If a credential for an unlock type is empty, it should not be touched.
+ // 3: Otherwise, the credential should be set to the new value.
+
+ bool update_pin = true;
+ std::string pin_credential;
+
+ // Compute needed changes.
+ for (size_t i = 0; i < params_->modes.size(); ++i) {
+ const QuickUnlockMode mode = params_->modes[i];
+ const std::string& credential = params_->credentials[i];
+
+ if (mode == quick_unlock_private::QUICK_UNLOCK_MODE_PIN) {
+ update_pin = !credential.empty();
+ pin_credential = credential;
+ }
+ }
+
+ // Apply changes.
+ if (update_pin) {
+ Profile* profile = chrome_details_.GetProfile();
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForProfile(profile);
+
+ if (pin_credential.empty())
+ pin_storage->RemovePin();
+ else
+ pin_storage->SetPin(pin_credential);
+ }
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698