chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 1968083004: Implement the private API for quick unlock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 1968083004: Implement the private API for quick unlock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index c4948140abe58da46d9f41c3a4c825b3617bee0e..00120bb7ad540c24d9b1f71be93d0b1bbc09578c 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -46,7 +46,7 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{APIPermission::kIdentity, "identity"},

{APIPermission::kIdentityEmail, "identity.email"},

{APIPermission::kExperimental, "experimental",

- APIPermissionInfo::kFlagCannotBeOptional},

Devlin 2016/06/01 17:44:13 We shouldn't update existing permissions in this p

jdufault 2016/06/03 23:13:16 Done, not sure how that happened.

+ APIPermissionInfo::kFlagNone},

{APIPermission::kEmbeddedExtensionOptions, "embeddedExtensionOptions",

APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kGeolocation, "geolocation",

@@ -199,6 +199,8 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kResourcesPrivate, "resourcesPrivate",

APIPermissionInfo::kFlagCannotBeOptional},

+ {APIPermission::kQuickUnlockPrivate, "quickUnlockPrivate",

+ APIPermissionInfo::kFlagCannotBeOptional},

// Full url access permissions.

{APIPermission::kDebugger, "debugger",