Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1968063002: Handle more corner cases of closures while doing ast-based summaries. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle more corner cases of closures while doing ast-based summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/70a913f5260b521aa51560f366fb23d7ec4c0b2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -41 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 9 chunks +24 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +48 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-11 12:35:27 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-11 15:30:50 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-11 15:41:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
70a913f5260b521aa51560f366fb23d7ec4c0b2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698