Certificate Transparency: Notify STH Observers of known STHs

net/cert/signed_tree_head.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/signed_tree_head.h"
 
 #include <string.h>
 
 #include <ostream>
 
@@ skipping 27 matching lines @@
         << "\t\"version\": " << sth.version << ",\n"
         << "\t\"timestamp\": " << sth.timestamp << ",\n"
         << "\t\"tree_size\": " << sth.tree_size << ",\n"
         << "\t\"sha256_root_hash\": \""
         << base::HexEncode(sth.sha256_root_hash, kSthRootHashLength)
         << "\",\n\t\"log_id\": \""
         << base::HexEncode(sth.log_id.data(), sth.log_id.size()) << "\"\n"
         << "}";
 }
 
+bool operator==(const SignedTreeHead& lhs, const SignedTreeHead& rhs) {
+  return lhs.version == rhs.version && lhs.timestamp == rhs.timestamp &&
+         lhs.tree_size == rhs.tree_size && lhs.log_id == rhs.log_id &&

[Ryan Sleevi, 2016/05/17 22:20:16]

fwiw, you could use

return std::tie(lhs.version, lhs.timestamp, lhs.tree_size, lhs.log_id) ==
    std::tie(rhs.version, rhs.timestamp, rhs.tree_size, rhs.log_id) &&
    memcmp(...) == 0 &&
    lhs.signature.SignatureParamsMatch(...) &&
    lhs.signature.signature_data == ...

If you opt-not to (fine), or do, drop the extra parens around the memcmp and
lhs.signature.SignatureParametersMatch

[Eran Messeri, 2016/05/18 10:37:20]

Done - switched to using std::tie and removed the extra parens.

+         (memcmp(lhs.sha256_root_hash, rhs.sha256_root_hash,
+                 kSthRootHashLength) == 0) &&
+         (lhs.signature.SignatureParametersMatch(
+             rhs.signature.hash_algorithm,
+             rhs.signature.signature_algorithm)) &&
+         lhs.signature.signature_data == rhs.signature.signature_data;
+}
+
+bool operator!=(const SignedTreeHead& lhs, const SignedTreeHead& rhs) {
+  return !operator==(lhs, rhs);

[Ryan Sleevi, 2016/05/17 22:20:16]

!(lhs == rhs)

No need to directly invoke operator== here (we only do that for the
member-methods, which are discouraged by
https://google.github.io/styleguide/cppguide.html#Operator_Overloading anyways)

[Eran Messeri, 2016/05/18 10:37:20]

Done.

+}
+
 }  // namespace ct
 }  // namespace net