Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1968033002: Implement everything in test Future-class to avoid analyzer warnings. (Closed)

Created:
4 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement everything in test Future-class to avoid analyzer warnings. Committed: https://github.com/dart-lang/sdk/commit/06676c4719fa1cda48d2e4a0436f3b501e86efd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tests/lib/async/future_test.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
TBR
4 years, 7 months ago (2016-05-11 11:43:45 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 06676c4719fa1cda48d2e4a0436f3b501e86efd9 (presubmit successful).
4 years, 7 months ago (2016-05-11 11:43:55 UTC) #4
floitsch
4 years, 7 months ago (2016-05-11 12:01:54 UTC) #5
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698