Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1967983002: [Smart Lock] Make save prompt first run experience never appear. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Make save prompt first run experience never appear. BUG=610950 Committed: https://crrev.com/b065df589003a17094e96232455bc51f9515dad3 Cr-Commit-Position: refs/heads/master@{#392883}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M components/password_manager/core/browser/password_bubble_experiment.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/password_manager/core/browser/password_bubble_experiment_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967983002/1
4 years, 7 months ago (2016-05-11 07:15:02 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/3635)
4 years, 7 months ago (2016-05-11 07:26:35 UTC) #5
melandory
Hi Vaclav, PTAL. This is small easy mergable fix, I'll nuke FRE for save prompt ...
4 years, 7 months ago (2016-05-11 08:47:20 UTC) #7
vabr (Chromium)
Your Cl and plan LGTM. Thanks for making the hotfix easily mergeable! Cheers, Vaclav
4 years, 7 months ago (2016-05-11 09:06:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967983002/20001
4 years, 7 months ago (2016-05-11 09:20:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 09:23:39 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 09:25:20 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b065df589003a17094e96232455bc51f9515dad3
Cr-Commit-Position: refs/heads/master@{#392883}

Powered by Google App Engine
This is Rietveld 408576698