Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
index fc8c73ca7a6b80436281c1f843ff032dbc86860e..12346279e4b3d66f3751a8777ef184f4346486f4 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
@@ -32,7 +32,9 @@ public:
virtual ~V8InspectorSession() { }
- virtual void setClient(V8InspectorSessionClient*) = 0;
+ static bool isV8ProtocolMethod(const String16& method);
+ virtual void dispatchProtocolMessage(const String16& message) = 0;
+ virtual String16 stateJSON() = 0;
virtual void addInspectedObject(PassOwnPtr<Inspectable>) = 0;
// API for the embedder to report native activities.
@@ -41,6 +43,8 @@ public:
virtual void breakProgram(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;
virtual void breakProgramOnException(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;
virtual void setSkipAllPauses(bool) = 0;
+ virtual void resume() = 0;
+ virtual void stepOver() = 0;
// API to report async call stacks.
virtual void asyncTaskScheduled(const String16& taskName, void* task, bool recurring) = 0;
@@ -55,11 +59,6 @@ public:
virtual PassOwnPtr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) = 0;
virtual v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* objectGroup = nullptr) = 0;
virtual void releaseObjectGroup(const String16&) = 0;
-
- virtual V8DebuggerAgent* debuggerAgent() = 0;
- virtual V8HeapProfilerAgent* heapProfilerAgent() = 0;
- virtual V8ProfilerAgent* profilerAgent() = 0;
- virtual V8RuntimeAgent* runtimeAgent() = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698