Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
index 0003fb438128f707c5b2f57de27e44ccca6e4da7..1a5e91c5fa3dc729b5f32a9526f4e824a6cf6127 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
@@ -16,6 +16,7 @@ namespace blink {
class V8ContextInfo;
class V8DebuggerClient;
class V8InspectorSession;
+class V8InspectorSessionClient;
class V8StackTrace;
namespace protocol {
@@ -24,15 +25,6 @@ class DictionaryValue;
class PLATFORM_EXPORT V8Debugger {
public:
- template <typename T>
- class Agent {
- public:
- virtual void setInspectorState(protocol::DictionaryValue*) = 0;
- virtual void setFrontend(T*) = 0;
- virtual void clearFrontend() = 0;
- virtual void restore() = 0;
- };
-
static PassOwnPtr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);
virtual ~V8Debugger() { }
@@ -48,7 +40,7 @@ public:
virtual void idleStarted() = 0;
virtual void idleFinished() = 0;
- virtual PassOwnPtr<V8InspectorSession> connect(int contextGroupId) = 0;
+ virtual PassOwnPtr<V8InspectorSession> connect(int contextGroupId, V8InspectorSessionClient*, const String16* state) = 0;
virtual bool isPaused() = 0;
static v8::Local<v8::Private> scopeExtensionPrivate(v8::Isolate*);

Powered by Google App Engine
This is Rietveld 408576698