Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
index 4a7a0593e03a496068e16024d1a95163e9056ffb..d5d0aa1bb61f9f7c883290c86ba834c6c4f3eecf 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
@@ -121,11 +121,11 @@ public:
String16 m_title;
};
-V8ProfilerAgentImpl::V8ProfilerAgentImpl(V8InspectorSessionImpl* session)
+V8ProfilerAgentImpl::V8ProfilerAgentImpl(V8InspectorSessionImpl* session, protocol::Frontend::Profiler* frontend, protocol::DictionaryValue* state)
: m_session(session)
, m_isolate(m_session->debugger()->isolate())
- , m_state(nullptr)
- , m_frontend(nullptr)
+ , m_state(state)
+ , m_frontend(frontend)
, m_enabled(false)
, m_recordingCPUProfile(false)
{
@@ -211,14 +211,6 @@ void V8ProfilerAgentImpl::setSamplingInterval(ErrorString* error, int interval)
m_isolate->GetCpuProfiler()->SetSamplingInterval(interval);
}
-void V8ProfilerAgentImpl::clearFrontend()
-{
- ErrorString error;
- disable(&error);
- DCHECK(m_frontend);
- m_frontend = nullptr;
-}
-
void V8ProfilerAgentImpl::restore()
{
DCHECK(!m_enabled);

Powered by Google App Engine
This is Rietveld 408576698