Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
index 77e4abc54eb6734b4828eab98d914fb2d9eb31c3..77f7f535de22a685204afc58f4a11e22998943ed 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
@@ -149,9 +149,11 @@ private:
} // namespace
-V8HeapProfilerAgentImpl::V8HeapProfilerAgentImpl(V8InspectorSessionImpl* session)
+V8HeapProfilerAgentImpl::V8HeapProfilerAgentImpl(V8InspectorSessionImpl* session, protocol::Frontend::HeapProfiler* frontend, protocol::DictionaryValue* state)
: m_session(session)
, m_isolate(session->debugger()->isolate())
+ , m_frontend(frontend)
+ , m_state(state)
, m_hasTimer(false)
{
}
@@ -160,14 +162,6 @@ V8HeapProfilerAgentImpl::~V8HeapProfilerAgentImpl()
{
}
-void V8HeapProfilerAgentImpl::clearFrontend()
-{
- ErrorString error;
- disable(&error);
- DCHECK(m_frontend);
- m_frontend = nullptr;
-}
-
void V8HeapProfilerAgentImpl::restore()
{
if (m_state->booleanProperty(HeapProfilerAgentState::heapProfilerEnabled, false))

Powered by Google App Engine
This is Rietveld 408576698