Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
index 5c2425fd583c038d88c955f3a7724b8359abc0f4..a5e8d5dda5599aa20d74e0e07248f71b3806bc5d 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
@@ -5,12 +5,11 @@
#ifndef V8DebuggerAgentImpl_h
#define V8DebuggerAgentImpl_h
+#include "platform/inspector_protocol/Backend.h"
#include "platform/inspector_protocol/Collections.h"
-#include "platform/inspector_protocol/Dispatcher.h"
#include "platform/inspector_protocol/Frontend.h"
#include "platform/inspector_protocol/String16.h"
#include "platform/v8_inspector/V8DebuggerImpl.h"
-#include "platform/v8_inspector/public/V8DebuggerAgent.h"
namespace blink {
@@ -26,7 +25,7 @@ class DictionaryValue;
using protocol::Maybe;
-class V8DebuggerAgentImpl : public V8DebuggerAgent {
+class V8DebuggerAgentImpl : public protocol::Backend::Debugger {
PROTOCOL_DISALLOW_COPY(V8DebuggerAgentImpl);
public:
enum SkipPauseRequest {
@@ -43,17 +42,13 @@ public:
MonitorCommandBreakpointSource
};
- explicit V8DebuggerAgentImpl(V8InspectorSessionImpl*);
+ V8DebuggerAgentImpl(V8InspectorSessionImpl*, protocol::Frontend::Debugger*, protocol::DictionaryValue* state);
~V8DebuggerAgentImpl() override;
-
- void setInspectorState(protocol::DictionaryValue*) override;
- void setFrontend(protocol::Frontend::Debugger* frontend) override { m_frontend = frontend; }
- void clearFrontend() override;
- void restore() override;
- void disable(ErrorString*) override;
+ void restore();
// Part of the protocol.
void enable(ErrorString*) override;
+ void disable(ErrorString*) override;
void setBreakpointsActive(ErrorString*, bool active) override;
void setSkipAllPauses(ErrorString*, bool skipped) override;
void setBreakpointByUrl(ErrorString*,

Powered by Google App Engine
This is Rietveld 408576698