Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
index a249d86873606f05dacc2258e6ff38f46e0063ce..2b02413cf4d40ff0d7ed78a6c48f57f17b68f48e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
@@ -155,12 +155,12 @@ static PassOwnPtr<protocol::Debugger::Location> buildProtocolLocation(const Stri
.setColumnNumber(columnNumber).build();
}
-V8DebuggerAgentImpl::V8DebuggerAgentImpl(V8InspectorSessionImpl* session)
+V8DebuggerAgentImpl::V8DebuggerAgentImpl(V8InspectorSessionImpl* session, protocol::Frontend::Debugger* frontend, protocol::DictionaryValue* state)
: m_debugger(session->debugger())
, m_session(session)
, m_enabled(false)
- , m_state(nullptr)
- , m_frontend(nullptr)
+ , m_state(state)
+ , m_frontend(frontend)
, m_isolate(m_debugger->isolate())
, m_breakReason(protocol::Debugger::Paused::ReasonEnum::Other)
, m_scheduledDebuggerStep(NoStep)
@@ -272,19 +272,6 @@ void V8DebuggerAgentImpl::internalSetAsyncCallStackDepth(int depth)
}
}
-void V8DebuggerAgentImpl::setInspectorState(protocol::DictionaryValue* state)
-{
- m_state = state;
-}
-
-void V8DebuggerAgentImpl::clearFrontend()
-{
- ErrorString error;
- disable(&error);
- DCHECK(m_frontend);
- m_frontend = nullptr;
-}
-
void V8DebuggerAgentImpl::restore()
{
DCHECK(!m_enabled);

Powered by Google App Engine
This is Rietveld 408576698