third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template - Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py ('K') | « third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Frontend_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

index 58c7691d59daed37a59c1c1a85a7eb2fdeace944..d65e35c7f9a3567e692ff39135b0e398e7670c41 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

@@ -44,7 +44,7 @@ void Frontend::{{domain.domain}}::{{event.name}}(

{% endfor %}

jsonMessage->setObject("params", std::move(paramsObject));

if (m_frontendChannel)

- m_frontendChannel->sendProtocolNotification(std::move(jsonMessage));

+ m_frontendChannel->sendProtocolNotification(jsonMessage->toJSONString());

}

{% endfor %}