Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
index d0c7797dfb60bea76ad437872c99afdc47c0dd4d..cda88f7a0dbfa068e81ed9b923f3590ba0da2c30 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
+++ b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
@@ -23,7 +23,7 @@ public:
class PLATFORM_EXPORT CallbackBase {
public:
- CallbackBase(PassOwnPtr<DispatcherImplWeakPtr> backendImpl, int sessionId, int id);
+ CallbackBase(PassOwnPtr<DispatcherImplWeakPtr> backendImpl, int callId);
virtual ~CallbackBase();
void sendFailure(const ErrorString&);
void dispose();
@@ -33,8 +33,7 @@ public:
private:
OwnPtr<DispatcherImplWeakPtr> m_backendImpl;
- int m_sessionId;
- int m_id;
+ int m_callId;
};
{% for domain in api.domains %}
@@ -53,9 +52,9 @@ public:
LastEntry,
};
- void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String16& errorMessage) const;
- virtual void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String16& errorMessage, ErrorSupport*) const = 0;
- virtual void dispatch(int sessionId, const String16& message) = 0;
+ void reportProtocolError(int callId, CommonErrorCode, const String16& errorMessage) const;
+ virtual void reportProtocolError(int callId, CommonErrorCode, const String16& errorMessage, ErrorSupport*) const = 0;
+ virtual void dispatch(const String16& message) = 0;
static bool getCommandName(const String16& message, String16* result);
};

Powered by Google App Engine
This is Rietveld 408576698