third_party/WebKit/Source/core/workers/WorkerThread.cpp - Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py ('K') | « third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

index 6b7d213e9c0177dc51227963c2be5e9162a4d474..0278511f08aea44ffd3b425f09c1becc1696f143 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

@@ -247,6 +247,7 @@ void WorkerThread::shutdown()

// This should be called before we start the shutdown procedure.

workerReportingProxy().willDestroyWorkerGlobalScope();

+ InspectorInstrumentation::allAsyncTasksCanceled(workerGlobalScope());

workerGlobalScope()->dispose();

workerBackingThread().backingThread().removeTaskObserver(m_microtaskRunner.get());

@@ -377,7 +378,6 @@ void WorkerThread::terminateInternal()

}

- InspectorInstrumentation::allAsyncTasksCanceled(m_workerGlobalScope.get());

m_inspectorTaskRunner->kill();

workerBackingThread().backingThread().postTask(BLINK_FROM_HERE, threadSafeBind(&WorkerThread::shutdown, AllowCrossThreadAccess(this)));

}