Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: content/renderer/devtools/devtools_agent_filter.cc

Issue 1967933002: [DevTools] Dispatch messages to V8InspectorSession directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1936593002
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/devtools/devtools_agent_filter.cc
diff --git a/content/renderer/devtools/devtools_agent_filter.cc b/content/renderer/devtools/devtools_agent_filter.cc
index 0ccf71b20a47458479860616a1678efd4dab5eb1..1e015f7910ffdd17045d4c4dece74b0462e19a84 100644
--- a/content/renderer/devtools/devtools_agent_filter.cc
+++ b/content/renderer/devtools/devtools_agent_filter.cc
@@ -21,8 +21,12 @@ namespace {
class MessageImpl : public WebDevToolsAgent::MessageDescriptor {
public:
- MessageImpl(const std::string& message, int routing_id)
- : msg_(message),
+ MessageImpl(
+ const std::string& method,
+ const std::string& message,
+ int routing_id)
+ : method_(method),
+ msg_(message),
routing_id_(routing_id) {
}
~MessageImpl() override {}
@@ -33,8 +37,10 @@ class MessageImpl : public WebDevToolsAgent::MessageDescriptor {
return agent->GetWebAgent();
}
WebString message() override { return WebString::fromUTF8(msg_); }
+ WebString method() override { return WebString::fromUTF8(method_); }
private:
+ std::string method_;
std::string msg_;
int routing_id_;
};
@@ -72,7 +78,7 @@ void DevToolsAgentFilter::OnDispatchOnInspectorBackend(
if (WebDevToolsAgent::shouldInterruptForMethod(
WebString::fromUTF8(method))) {
WebDevToolsAgent::interruptAndDispatch(
- session_id, new MessageImpl(message, current_routing_id_));
+ session_id, new MessageImpl(method, message, current_routing_id_));
}
}

Powered by Google App Engine
This is Rietveld 408576698