Add seccomp sandbox for non-SFI NaCl

components/nacl/loader/nonsfi/nonsfi_main.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/loader/nonsfi/nonsfi_main.h"
 
 #include "base/debug/leak_annotations.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/platform_thread.h"
@@ skipping 160 matching lines @@
     LOG(ERROR) << "ServiceAccept: Failed to accept " << status;
     return;
   }
 
   NaClSrpcServerLoop(connected_desc, kNonSfiServiceHandlers, NULL);
 }
 
 }  // namespace
 
 void MainStart(NaClHandle imc_bootstrap_handle) {
-  NaClSrpcModuleInit();

[hamaji, 2014/03/24 16:25:43]

This was called from here for historical reason, I think. Hidehiko introduced
this file first, but now this module is initialized in NaClChromeMainInit, so we
don't need this anymore.

[Mark Seaborn, 2014/03/28 01:38:25]

Calling NaClChromeMainInit() for the non-SFI code path is somewhat accidental,
though.  Was there a problem with calling NaClSrpcModuleInit() twice?  There's
nothing wrong with removing this call, but AFAICT it's not related to tightening
up the sandbox.

Could you send this for review as a separate change, please?

[hamaji, 2014/03/28 12:06:10]

I'll send a patch after https://codereview.chromium.org/209423004/ is landed,
and then return to this change.

-
   struct NaClDesc* secure_pair[2] = { NULL, NULL };
   struct NaClDesc* pair[2] = { NULL, NULL };
   CreateSecureSocketPair(secure_pair, pair);
   ::scoped_ptr<struct NaClDesc, NaClDescUnrefer> secure_port(secure_pair[0]);
   ::scoped_ptr<struct NaClDesc, NaClDescUnrefer> secure_address(
        secure_pair[1]);
   ::scoped_ptr<struct NaClDesc, NaClDescUnrefer> service_port(pair[0]);
   ::scoped_ptr<struct NaClDesc, NaClDescUnrefer> service_address(pair[1]);
 
   ::scoped_ptr<struct NaClDesc, NaClDescUnrefer> channel(
        SetUpBootstrapChannel(imc_bootstrap_handle,
                              secure_address.get(), service_address.get()));
   if (!channel) {
     LOG(ERROR) << "MainStart: Failed to set up bootstrap channel.";
     return;
   }
 
   // Start the SRPC server loop.
   ServiceAccept(secure_port.get());
 }
 
 }  // namespace nonsfi
 }  // namespace nacl