Add seccomp sandbox for non-SFI NaCl

components/nacl/browser/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/browser/nacl_process_host.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 564 matching lines @@
       env->SetVar(kPath, new_path);
     }
 #endif  // _DLL
   }
 #endif
 
   scoped_ptr<CommandLine> cmd_line(new CommandLine(exe_path));
   CopyNaClCommandLineArguments(cmd_line.get());
 
   cmd_line->AppendSwitchASCII(switches::kProcessType,
+                              uses_nonsfi_mode_ ?

[Mark Seaborn, 2014/03/28 01:38:25]

Can you split out the parts that plumb through "uses_nonsfi_mode" to nacl_helper
into a separate change?

There's already a place where we're passing "uses_nonsfi_mode" to the
nacl_helper process.  nacl_listener.cc receives NaClProcessMsg_Start, which
contains this flag, but this isn't early enough for the seccomp-bpf sandboxing.

Rather than having two places where this is plumbed through, can you change
nacl_listener.cc to receive the flag via the new route you're adding? 
(Otherwise I'd worry that the two could get out of sync.)

[hamaji, 2014/03/28 12:06:10]

Thanks for the review! I've uploaded another CL for review.

https://codereview.chromium.org/216603002/

I'll update this CL based on your comments once it turned out the preparation
CLs seem to be OK.

+                              switches::kNaClNonSfiLoaderProcess :
                               switches::kNaClLoaderProcess);
   cmd_line->AppendSwitchASCII(switches::kProcessChannelID, channel_id);
   if (NaClBrowser::GetDelegate()->DialogsAreSuppressed())
     cmd_line->AppendSwitch(switches::kNoErrorDialogs);
 
   // On Windows we might need to start the broker process to launch a new loader
 #if defined(OS_WIN)
   if (RunningOnWOW64()) {
     if (!NaClBrokerService::GetInstance()->LaunchLoader(
             weak_factory_.GetWeakPtr(), channel_id)) {
@@ skipping 481 matching lines @@
         process_handle.Take(), info,
         base::MessageLoopProxy::current(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif
 
 }  // namespace nacl