Issue 196793015: A little more print debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196793015: A little more print debugging (Closed)

Created:
6 years, 9 months ago by borenet

Modified:
6 years, 9 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/buildbot.git@master

Visibility:
Public.

More Reviews

Description

A little more print debugging TBR=epoger BUG=skia:1329 Committed: https://skia.googlesource.com/buildbot/+/85ca4f5

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	scripts/run_cmd.py	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

borenet

Committed patchset #1 manually as r85ca4f5 (presubmit successful).

6 years, 9 months ago (2014-03-13 17:32:31 UTC) #1

epoger

6 years, 9 months ago (2014-03-13 17:42:45 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/196793015/diff/1/scripts/run_cmd.py
File scripts/run_cmd.py (right):

https://codereview.chromium.org/196793015/diff/1/scripts/run_cmd.py#newcode175
scripts/run_cmd.py:175: print ' '.join(cmd)
I would be tempted to 

print '_launch_cmd(): %s' % ' '.join(cmd)

Expand Messages | Collapse Messages