Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1967913003: X87: [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operator… (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. port 2da70f853d7f680d491c37c72d5ef04a85497ba9 (r36136) original commit message: Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in http://crrev.com/1962563003. Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. BUG= Committed: https://crrev.com/9af1f35fcc0f13d63ba8a985baccebb38dd031ed Cr-Commit-Position: refs/heads/master@{#36159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -13 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 3 chunks +58 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-11 07:16:14 UTC) #2
Weiliang
lgtm lgtm
4 years, 7 months ago (2016-05-11 07:42:46 UTC) #3
Weiliang
lgtm
4 years, 7 months ago (2016-05-11 07:42:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967913003/1
4 years, 7 months ago (2016-05-11 07:54:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 08:19:45 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:22:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9af1f35fcc0f13d63ba8a985baccebb38dd031ed
Cr-Commit-Position: refs/heads/master@{#36159}

Powered by Google App Engine
This is Rietveld 408576698