Material WebUI: cr-slider element for intelligent range mapping

chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
   'use strict';
 
   /**
    * This is the absolute difference maintained between standard and
    * fixed-width font sizes. http://crbug.com/91922.
@@ skipping 33 matching lines @@
       /** @private */
       advancedExtensionSublabel_: String,
 
       /** @private */
       advancedExtensionUrl_: String,
 
       /** @private {!settings.FontsBrowserProxy} */
       browserProxy_: Object,
 
       /**
-       * The font size used by default.
-       * @private
-       */
-      defaultFontSize_: {
-        type: Number,
-      },
-
-      /**
-       * The value of the font size slider.
-       * @private
-       */
-      fontSizeIndex_: {
-        type: Number,
-      },
-
-      /**
        * Common font sizes.
        * @private {!Array<number>}
        */
       fontSizeRange_: {
         readOnly: true,
         type: Array,
         value: FONT_SIZE_RANGE_,
       },
 
       /**
-       * Upper bound of the font size slider.
-       * @private
-       */
-      fontSizeRangeLimit_: {
-        readOnly: true,
-        type: Number,
-        value: FONT_SIZE_RANGE_.length - 1,
-      },
-
-      /**
-       * The interactive value of the minimum font size slider.
-       * @private
-       */
-      immediateMinimumSizeIndex_: {
-        observer: 'immediateMinimumSizeIndexChanged_',
-        type: Number,
-      },
-
-      /**
-       * The interactive value of the font size slider.
-       * @private
-       */
-      immediateSizeIndex_: {
-        observer: 'immediateSizeIndexChanged_',
-        type: Number,
-      },
-
-      /**
        * Reasonable, minimum font sizes.
        * @private {!Array<number>}
        */
       minimumFontSizeRange_: {
         readOnly: true,
         type: Array,
         value: MINIMUM_FONT_SIZE_RANGE_,
       },
 
       /**
-       * Upper bound of the minimum font size slider.
-       * @private
-       */
-      minimumFontSizeRangeLimit_: {
-        readOnly: true,
-        type: Number,
-        value: MINIMUM_FONT_SIZE_RANGE_.length - 1,
-      },
-
-      /**
-       * The font size used at minimum.
-       * @private
-       */
-      minimumFontSize_: {
-        type: Number,
-      },
-
-      /**
-       * The value of the minimum font size slider.
-       * @private
-       */
-      minimumSizeIndex_: {
-        type: Number,
-      },
-
-      /**
        * Preferences state.
        */
       prefs: {
         type: Object,
         notify: true,
       },
     },
 
     observers: [
       'fontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
-      'minimumFontSizeChanged_(prefs.webkit.webprefs.minimum_font_size.value)',
     ],
 
     /** @override */
     created: function() {
       this.browserProxy_ = settings.FontsBrowserProxyImpl.getInstance();
     },
 
     /** @override */
     ready: function() {
       this.addWebUIListener('advanced-font-settings-installed',
           this.setAdvancedExtensionInstalled_.bind(this));
       this.browserProxy_.observeAdvancedFontExtensionAvailable();
 
       this.browserProxy_.fetchFontsData().then(
           this.setFontsData_.bind(this));
     },
 
-    /**
-     * @param {number} value The intermediate slider value.
-     * @private
-     */
-    immediateSizeIndexChanged_: function(value) {
-      this.set('prefs.webkit.webprefs.default_font_size.value',
-          this.fontSizeRange_[this.immediateSizeIndex_]);
-    },
-
-    /**
-     * @param {number} value The intermediate slider value.
-     * @private
-     */
-    immediateMinimumSizeIndexChanged_: function(value) {
-      this.set('prefs.webkit.webprefs.minimum_font_size.value',
-          this.minimumFontSizeRange_[this.immediateMinimumSizeIndex_]);
-    },
-
     /** @private */
     openAdvancedExtension_: function() {
       if (this.advancedExtensionInstalled_)
         this.browserProxy_.openAdvancedFontSettings();
       else
         window.open(this.advancedExtensionUrl_);
     },
 
     /**
      * @param {boolean} isInstalled Whether the advanced font settings
@@ skipping 33 matching lines @@
       }
       this.$.encoding.menuOptions = encodingMenuOptions;
       this.advancedExtensionUrl_ = response.extensionUrl;
     },
 
     /**
      * @param {number} value The changed font size slider value.
      * @private
      */
     fontSizeChanged_: function(value) {
-      this.defaultFontSize_ = value;
-      if (!this.$.sizeSlider.dragging) {
-        this.fontSizeIndex_ = this.fontSizeRange_.indexOf(value);
-        this.set('prefs.webkit.webprefs.default_fixed_font_size.value',
+      // TODO(dschuyler): Actually fetch this pref so setting it does something.

[dschuyler, 2016/05/16 20:49:50]

A TODO should have the name of the person who wrote the
todo (or someone who can explain the comment furture --
I'm not sure what the comment is saying).

[stevenjb, 2016/05/16 21:57:51]

FWIW, it's OK to put someone else's name on a TODO, but they should review it
and understand what you mean :) It is also useful to have an issue associated
witha TODO.

[michaelpg, 2016/05/17 19:18:43]

Done.

+      this.set('prefs.webkit.webprefs.default_fixed_font_size.value',
           value - SIZE_DIFFERENCE_FIXED_STANDARD_);
-      }
     },
 
     /**
-     * @param {number} value The changed font size slider value.
-     * @private
-     */
-    minimumFontSizeChanged_: function(value) {
-      this.minimumFontSize_ = value;
-      if (!this.$.minimumSizeSlider.dragging)
-        this.minimumSizeIndex_ = this.minimumFontSizeRange_.indexOf(value);
-    },
-
-    /**
      * Creates an html style value.
      * @param {number} fontSize The font size to use.
      * @param {string} fontFamily The name of the font family use.
      * @return {string}
      * @private
      */
     computeStyle_: function(fontSize, fontFamily) {
       return 'font-size: ' + fontSize + "px; font-family: '" + fontFamily +
           "';";
     },
   });
 })();