Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.cc

Issue 19679002: <webview>: Implement dialog API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more tests and fixed a bug Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_bindings.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc
index 56b8e298b0bb04210b7a884554ec7cd54e55655b..c87e33b4ea28a54569427055cc610213f87382c9 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc
@@ -317,7 +317,7 @@ class BrowserPluginBindingSetPermission : public BrowserPluginMethodBinding {
public:
BrowserPluginBindingSetPermission()
: BrowserPluginMethodBinding(
- browser_plugin::kMethodInternalSetPermission, 2) {
+ browser_plugin::kMethodInternalSetPermission, 3) {
}
virtual bool Invoke(BrowserPluginBindings* bindings,
@@ -325,7 +325,9 @@ class BrowserPluginBindingSetPermission : public BrowserPluginMethodBinding {
NPVariant* result) OVERRIDE {
int request_id = IntFromNPVariant(args[0]);
bool allow = NPVARIANT_TO_BOOLEAN(args[1]);
- bindings->instance()->OnEmbedderDecidedPermission(request_id, allow);
+ std::string user_input = StringFromNPVariant(args[2]);
+ bindings->instance()->OnEmbedderDecidedPermission(
+ request_id, allow, user_input);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698