Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 19679002: <webview>: Implement dialog API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more tests and fixed a bug Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index b3e0f4b493cfc5e4622957629401a0726e37a31e..88481d50e66e07f1e2f8f47757b0811cf5a45ce0 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -132,7 +132,8 @@ class CONTENT_EXPORT BrowserPlugin :
gfx::Point ToLocalCoordinates(const gfx::Point& point) const;
// Called by browser plugin binding.
- void OnEmbedderDecidedPermission(int request_id, bool allow);
+ void OnEmbedderDecidedPermission(int request_id, bool allow,
+ const std::string& user_input);
// Attaches this BrowserPlugin to a guest with the provided |instance_id|.
// If the |instance_id| is not yet associated with a guest, a new guest
@@ -297,7 +298,8 @@ class CONTENT_EXPORT BrowserPlugin :
// allowed or denied by the embedder.
void RespondPermission(BrowserPluginPermissionType permission_type,
int request_id,
- bool allow);
+ bool allow,
+ const std::string& user_input);
// Handles the response to the pointerLock permission request.
void RespondPermissionPointerLock(bool allow);
@@ -305,7 +307,9 @@ class CONTENT_EXPORT BrowserPlugin :
// If the request with id |request_id| is pending then informs the
// BrowserPlugin that the guest's permission request has been allowed or
// denied by the embedder.
- void RespondPermissionIfRequestIsPending(int request_id, bool allow);
+ void RespondPermissionIfRequestIsPending(int request_id,
+ bool allow,
+ const std::string& user_input);
// Called when the tracked object of |id| ID becomes unreachable in
// JavaScript.

Powered by Google App Engine
This is Rietveld 408576698