Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2603)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 19679002: <webview>: Implement dialog API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more tests and fixed a bug Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index f249350982ffdfdb8073577dd36ea8bb9eb609d9..327bfca4bacf0e2bb76c8f97e4d7ca6dca50eb65 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -438,7 +438,7 @@ WebView.prototype.setupNewWindowEvent_ = function() {
var detail = e.detail ? JSON.parse(e.detail) : {};
if (detail.id != requestId)
return;
- browserPluginNode['-internal-setPermission'](requestId, false);
+ browserPluginNode['-internal-setPermission'](requestId, false, '');
}
browserPluginNode.addEventListener('-internal-newwindow', function(e) {
@@ -478,12 +478,12 @@ WebView.prototype.setupNewWindowEvent_ = function() {
// then we will fail and it will be treated as if the new window
// was rejected. The permission API plumbing is used here to clean
// up the state created for the new window if attaching fails.
- browserPluginNode['-internal-setPermission'](requestId, attached);
+ browserPluginNode['-internal-setPermission'](requestId, attached, '');
}, 0);
},
discard: function() {
validateCall();
- browserPluginNode['-internal-setPermission'](requestId, false);
+ browserPluginNode['-internal-setPermission'](requestId, false, '');
}
};
evt.window = window;
@@ -498,7 +498,7 @@ WebView.prototype.setupNewWindowEvent_ = function() {
if (!actionTaken && !defaultPrevented) {
actionTaken = true;
// The default action is to discard the window.
- browserPluginNode['-internal-setPermission'](requestId, false);
+ browserPluginNode['-internal-setPermission'](requestId, false, '');
console.warn(WARNING_MSG_NEWWINDOW_BLOCKED);
}
});
@@ -567,7 +567,7 @@ WebView.prototype.setupPermissionEvent_ = function() {
var detail = e.detail ? JSON.parse(e.detail) : {};
if (detail.id != requestId)
return;
- browserPluginNode['-internal-setPermission'](requestId, false);
+ browserPluginNode['-internal-setPermission'](requestId, false, '');
}
browserPluginNode.addEventListener(internalevent, function(e) {
@@ -590,7 +590,7 @@ WebView.prototype.setupPermissionEvent_ = function() {
if (decisionMade) {
throw new Error(ERROR_MSG_PERMISSION_ALREADY_DECIDED);
} else {
- browserPluginNode['-internal-setPermission'](requestId, true);
+ browserPluginNode['-internal-setPermission'](requestId, true, '');
decisionMade = true;
}
},
@@ -598,7 +598,7 @@ WebView.prototype.setupPermissionEvent_ = function() {
if (decisionMade) {
throw new Error(ERROR_MSG_PERMISSION_ALREADY_DECIDED);
} else {
- browserPluginNode['-internal-setPermission'](requestId, false);
+ browserPluginNode['-internal-setPermission'](requestId, false, '');
decisionMade = true;
}
}
@@ -615,7 +615,7 @@ WebView.prototype.setupPermissionEvent_ = function() {
var defaultPrevented = !node.dispatchEvent(evt);
if (!decisionMade && !defaultPrevented) {
decisionMade = true;
- browserPluginNode['-internal-setPermission'](requestId, false);
+ browserPluginNode['-internal-setPermission'](requestId, false, '');
}
}
});

Powered by Google App Engine
This is Rietveld 408576698