Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Side by Side Diff: chrome/browser/resources/settings/people_page/sync_browser_proxy.js

Issue 1967883002: Settings People Revamp: Fix some small bugs in the handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the failing test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A helper object used from the the People section to get the 6 * @fileoverview A helper object used from the the People section to get the
7 * status of the sync backend and user preferences on what data to sync. Used 7 * status of the sync backend and user preferences on what data to sync. Used
8 * for both Chrome browser and ChromeOS. 8 * for both Chrome browser and ChromeOS.
9 */ 9 */
10 cr.exportPath('settings'); 10 cr.exportPath('settings');
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 </if> 183 </if>
184 184
185 /** @override */ 185 /** @override */
186 getSyncStatus: function() { 186 getSyncStatus: function() {
187 return cr.sendWithPromise('SyncSetupGetSyncStatus'); 187 return cr.sendWithPromise('SyncSetupGetSyncStatus');
188 }, 188 },
189 189
190 /** @override */ 190 /** @override */
191 showSetupUI: function() { 191 showSetupUI: function() {
192 chrome.send('SyncSetupShowSetupUI'); 192 chrome.send('SyncSetupShowSetupUI');
193 chrome.send('coreOptionsUserMetricsAction', ['Options_ShowSyncAdvanced']);
194 }, 193 },
195 194
196 /** @override */ 195 /** @override */
197 didNavigateToSyncPage: function() { 196 didNavigateToSyncPage: function() {
198 chrome.send('SyncSetupShowSetupUI'); 197 chrome.send('SyncSetupShowSetupUI');
199 }, 198 },
200 199
201 /** @override */ 200 /** @override */
202 didNavigateAwayFromSyncPage: function() { 201 didNavigateAwayFromSyncPage: function() {
203 chrome.send('SyncSetupDidClosePage'); 202 chrome.send('SyncSetupDidClosePage');
(...skipping 16 matching lines...) Expand all
220 chrome.metricsPrivate.recordUserAction( 219 chrome.metricsPrivate.recordUserAction(
221 'Signin_AccountSettings_GoogleActivityControlsClicked'); 220 'Signin_AccountSettings_GoogleActivityControlsClicked');
222 window.open(loadTimeData.getString('activityControlsUrl')); 221 window.open(loadTimeData.getString('activityControlsUrl'));
223 } 222 }
224 }; 223 };
225 224
226 return { 225 return {
227 SyncBrowserProxyImpl: SyncBrowserProxyImpl, 226 SyncBrowserProxyImpl: SyncBrowserProxyImpl,
228 }; 227 };
229 }); 228 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698