Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1967883002: Settings People Revamp: Fix some small bugs in the handler (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Fix some small bugs in the handler BUG=563721, 610599, 610579 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/573ca551d58dee154aa216536bfbbc1bd0ca22a3 Cr-Commit-Position: refs/heads/master@{#393069}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Fix the failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M chrome/browser/resources/settings/people_page/sync_browser_proxy.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 1 2 3 9 chunks +23 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
tommycli
dpapad: PTAL, thanks! https://codereview.chromium.org/1967883002/diff/40001/chrome/browser/resources/settings/people_page/sync_browser_proxy.js File chrome/browser/resources/settings/people_page/sync_browser_proxy.js (left): https://codereview.chromium.org/1967883002/diff/40001/chrome/browser/resources/settings/people_page/sync_browser_proxy.js#oldcode193 chrome/browser/resources/settings/people_page/sync_browser_proxy.js:193: chrome.send('coreOptionsUserMetricsAction', ['Options_ShowSyncAdvanced']); Leftovers from old Options ...
4 years, 7 months ago (2016-05-11 19:19:08 UTC) #5
dpapad
lgtm
4 years, 7 months ago (2016-05-11 19:35:58 UTC) #6
tommycli
On 2016/05/11 19:35:58, dpapad wrote: > lgtm thanks!
4 years, 7 months ago (2016-05-11 19:36:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967883002/40001
4 years, 7 months ago (2016-05-11 19:37:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/226037)
4 years, 7 months ago (2016-05-11 20:01:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967883002/60001
4 years, 7 months ago (2016-05-11 20:41:33 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-11 21:39:36 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 21:42:05 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/573ca551d58dee154aa216536bfbbc1bd0ca22a3
Cr-Commit-Position: refs/heads/master@{#393069}

Powered by Google App Engine
This is Rietveld 408576698