Settings People Revamp: Fix some small bugs in the handler

Settings People Revamp: Fix some small bugs in the handler

BUG=563721, 610599, 610579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/573ca551d58dee154aa216536bfbbc1bd0ca22a3
Cr-Commit-Position: refs/heads/master@{#393069}

[tommycli, 2016-05-10 23:48:10]

Description was changed from

==========
Settings People Revamp: Fix PushSyncPrefs bug

BUG=563721
==========

to

==========
Settings People Revamp: Fix PushSyncPrefs bug

BUG=563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-05-10 23:48:43]

Description was changed from

==========
Settings People Revamp: Fix PushSyncPrefs bug

BUG=563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix some small bugs

BUG=563721, 610599
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-05-11 18:28:31]

Description was changed from

==========
Settings People Revamp: Fix some small bugs

BUG=563721, 610599
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix some small bugs in the handler

BUG=563721, 610599, 610579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-05-11 19:19:07]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2016-05-11 19:19:08]

dpapad: PTAL, thanks!

https://codereview.chromium.org/1967883002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/sync_browser_proxy.js (left):

https://codereview.chromium.org/1967883002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/sync_browser_proxy.js:193:
chrome.send('coreOptionsUserMetricsAction', ['Options_ShowSyncAdvanced']);
Leftovers from old Options that causes a crash now.

https://codereview.chromium.org/1967883002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/1967883002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/people_handler.cc:801: void
PeopleHandler::PushSyncPrefs() {
This method was previously only called when the dialog was initially opened.

Since now this method is called in response to Sync preferences changes, some of
the DCHECKs turn into early exits.

[dpapad, 2016-05-11 19:35:58]

lgtm

[tommycli, 2016-05-11 19:36:46]

On 2016/05/11 19:35:58, dpapad wrote:
> lgtm

thanks!

[tommycli, 2016-05-11 19:36:53]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-05-11 19:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967883002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967883002/40001

[commit-bot: I haz the power, 2016-05-11 20:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:01:48]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2016-05-11 20:40:56]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-05-11 20:40:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1967883002/#ps60001
(title: "Fix the failing test")

[commit-bot: I haz the power, 2016-05-11 20:41:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967883002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967883002/60001

[commit-bot: I haz the power, 2016-05-11 21:39:35]

Description was changed from

==========
Settings People Revamp: Fix some small bugs in the handler

BUG=563721, 610599, 610579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix some small bugs in the handler

BUG=563721, 610599, 610579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-11 21:39:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-11 21:42:04]

Description was changed from

==========
Settings People Revamp: Fix some small bugs in the handler

BUG=563721, 610599, 610579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix some small bugs in the handler

BUG=563721, 610599, 610579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/573ca551d58dee154aa216536bfbbc1bd0ca22a3
Cr-Commit-Position: refs/heads/master@{#393069}
==========

[commit-bot: I haz the power, 2016-05-11 21:42:05]

Patchset 4 (id:??) landed as
https://crrev.com/573ca551d58dee154aa216536bfbbc1bd0ca22a3
Cr-Commit-Position: refs/heads/master@{#393069}