Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1967833002: Merge M51: "Add support for multichannel playback to OpenSLES output." (Closed)

Created:
4 years, 7 months ago by DaleCurtis
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge M51: "Add support for multichannel playback to OpenSLES output." Ports the code from AOSP for detecting channel layouts given a channel count. No idea if it works though since I'm not sure how to setup a multichannel android device. Notably this also changes the mono layout from using the center channel to using the left channel mask per notes in the ported code. Multichannel is only supported on Lollipop+ devices since OpenSLES does not configure successfully on any KitKat device I've tried. BUG=607003 TEST=multichannel test clip. Review-Url: https://codereview.chromium.org/1921963004 Cr-Commit-Position: refs/heads/master@{#391095} (cherry picked from commit 48c1c49bc3646cf90a59ad90260a43ff23001bf1) Committed: https://chromium.googlesource.com/chromium/src/+/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -13 lines) Patch
M media/audio/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 chunk +10 lines, -1 line 0 comments Download
M media/audio/android/opensles_input.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/audio/android/opensles_output.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/audio/android/opensles_util.h View 2 chunks +6 lines, -0 lines 0 comments Download
A media/audio/android/opensles_util.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 7 months ago (2016-05-10 22:20:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2bbdb83e7084bb2982bf026ed26f6480c0d64a4.

Powered by Google App Engine
This is Rietveld 408576698