Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 19678010: Improve null gpu's memory handling (Closed)

Created:
7 years, 5 months ago by robertphillips
Modified:
7 years, 5 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, tfarina
Visibility:
Public.

Description

Improve null gpu's memory handling

Patch Set 1 #

Patch Set 2 : fix compiler warning #

Total comments: 4

Patch Set 3 : Added recycling of buffer id slots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -46 lines) Patch
M gm/gmmain.cpp View 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 2 5 chunks +149 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years, 5 months ago (2013-07-18 15:21:08 UTC) #1
tfarina
https://codereview.chromium.org/19678010/diff/2001/src/gpu/gl/GrGLCreateNullInterface.cpp File src/gpu/gl/GrGLCreateNullInterface.cpp (right): https://codereview.chromium.org/19678010/diff/2001/src/gpu/gl/GrGLCreateNullInterface.cpp#newcode27 src/gpu/gl/GrGLCreateNullInterface.cpp:27: void allocate(GrGLint size, const GrGLchar *dataPtr) { nit: GrGLChar* ...
7 years, 5 months ago (2013-07-18 16:30:21 UTC) #2
robertphillips
https://codereview.chromium.org/19678010/diff/2001/src/gpu/gl/GrGLCreateNullInterface.cpp File src/gpu/gl/GrGLCreateNullInterface.cpp (right): https://codereview.chromium.org/19678010/diff/2001/src/gpu/gl/GrGLCreateNullInterface.cpp#newcode27 src/gpu/gl/GrGLCreateNullInterface.cpp:27: void allocate(GrGLint size, const GrGLchar *dataPtr) { On 2013/07/18 ...
7 years, 5 months ago (2013-07-18 16:59:31 UTC) #3
bsalomon
lgtm
7 years, 5 months ago (2013-07-18 17:16:22 UTC) #4
robertphillips
7 years, 5 months ago (2013-07-18 17:39:30 UTC) #5
Message was sent while issue was closed.
committed as r10148

Powered by Google App Engine
This is Rietveld 408576698