Issue 19678009: Use kPointerSize to compute the call instruction offset in the PatchedReturnSequence for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19678009: Use kPointerSize to compute the call instruction offset in the PatchedReturnSequence for X64 (Closed)

Created:
7 years, 5 months ago by haitao.feng

Modified:
7 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Use kPointerSize to compute the call instruction offset in the PatchedReturnSequence for X64

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/x64/assembler-x64-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

This is danno's comment on https://codereview.chromium.org/18014003. It will apply for X32 as well.

7 years, 5 months ago (2013-07-18 12:47:11 UTC) #1

haitao.feng

7 years, 5 months ago (2013-07-19 03:02:22 UTC) #3

danno, I migrate this CL to https://codereview.chromium.org/19763010/ which is
created by following https://code.google.com/p/v8/wiki/UsingGit. Could you write
a lgtm there and I could go with "git cl dcommit" to continue the following
process?

Expand Messages | Collapse Messages