Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19678004: Move UserScript and Extension switches to top-level extensions/. (Closed)

Created:
7 years, 5 months ago by Yoyo Zhou
Modified:
7 years, 5 months ago
Reviewers:
Matt Perry, sky
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, benjhayden+dwatch_chromium.org, tburkard+watch_chromium.org, dominich+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move UserScript and Extension switches to top-level extensions/. BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212549

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -782 lines) Patch
M chrome/browser/about_flags.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/page_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/script_executor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 4 chunks +0 lines, -19 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permissions_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/user_script.h View 1 chunk +0 lines, -260 lines 0 comments Download
D chrome/common/extensions/user_script.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/common/extensions/user_script_unittest.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
chrome/renderer/extensions/user_script_slave.h View 1 chunk +1 line, -1 line 0 comments Download
A extensions/common/switches.h View 1 chunk +23 lines, -0 lines 0 comments Download
A extensions/common/switches.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A + extensions/common/user_script.h View 2 chunks +3 lines, -3 lines 0 comments Download
extensions/common/user_script.cc View 1 chunk +2 lines, -2 lines 0 comments Download
extensions/common/user_script_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
mpcomplete: please review. sky: please review gyp and non-extensions (top-level chrome/browser/...flags and chrome/common/...switches)
7 years, 5 months ago (2013-07-17 22:19:30 UTC) #1
Matt Perry
Yay! LGTM https://codereview.chromium.org/19678004/diff/1/extensions/common/switches.cc File extensions/common/switches.cc (right): https://codereview.chromium.org/19678004/diff/1/extensions/common/switches.cc#newcode1 extensions/common/switches.cc:1: // Copyright 2013 The Chromium Authors. All ...
7 years, 5 months ago (2013-07-17 22:28:30 UTC) #2
Yoyo Zhou
https://codereview.chromium.org/19678004/diff/1/extensions/common/switches.cc File extensions/common/switches.cc (right): https://codereview.chromium.org/19678004/diff/1/extensions/common/switches.cc#newcode1 extensions/common/switches.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
7 years, 5 months ago (2013-07-17 22:36:13 UTC) #3
sky
LGTM
7 years, 5 months ago (2013-07-18 14:22:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/19678004/1
7 years, 5 months ago (2013-07-18 18:17:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=137197
7 years, 5 months ago (2013-07-19 00:01:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/19678004/23001
7 years, 5 months ago (2013-07-19 01:11:31 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-19 08:50:31 UTC) #8
Message was sent while issue was closed. 
Change committed as 212549

Powered by Google App Engine
This is Rietveld 408576698