Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: content/renderer/devtools/v8_sampling_profiler.cc

Issue 1967793004: Change base class of V8SamplingProfiler to AsyncEnabledStateObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address alph's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/v8_sampling_profiler.cc
diff --git a/content/renderer/devtools/v8_sampling_profiler.cc b/content/renderer/devtools/v8_sampling_profiler.cc
index c27f29b6990317682b100d84ddfe5de6a22bd633..02dad8e23f854295afbfe00d9b4abb32b840d288 100644
--- a/content/renderer/devtools/v8_sampling_profiler.cc
+++ b/content/renderer/devtools/v8_sampling_profiler.cc
@@ -13,7 +13,6 @@
#include "base/strings/stringprintf.h"
#include "base/synchronization/cancellation_flag.h"
#include "base/threading/platform_thread.h"
-#include "base/threading/thread_task_runner_handle.h"
#include "base/trace_event/trace_event.h"
#include "base/trace_event/trace_event_argument.h"
#include "build/build_config.h"
@@ -580,18 +579,19 @@ void V8SamplingThread::Stop() {
V8SamplingProfiler::V8SamplingProfiler(bool underTest)
: sampling_thread_(nullptr),
render_thread_sampler_(Sampler::CreateForCurrentThread()),
- task_runner_(base::ThreadTaskRunnerHandle::Get()) {
+ weak_factory_(this) {
DCHECK(underTest || RenderThreadImpl::current());
// Force the "v8.cpu_profile*" categories to show up in the trace viewer.
TraceLog::GetCategoryGroupEnabled(
TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"));
TraceLog::GetCategoryGroupEnabled(
TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile.hires"));
- TraceLog::GetInstance()->AddEnabledStateObserver(this);
+ TraceLog::GetInstance()->AddAsyncEnabledStateObserver(
+ weak_factory_.GetWeakPtr());
}
V8SamplingProfiler::~V8SamplingProfiler() {
- TraceLog::GetInstance()->RemoveEnabledStateObserver(this);
+ TraceLog::GetInstance()->RemoveAsyncEnabledStateObserver(this);
DCHECK(!sampling_thread_.get());
}
@@ -624,15 +624,11 @@ void V8SamplingProfiler::OnTraceLogEnabled() {
if (record_mode == base::trace_event::TraceRecordMode::RECORD_CONTINUOUSLY)
return;
- task_runner_->PostTask(FROM_HERE,
- base::Bind(&V8SamplingProfiler::StartSamplingThread,
- base::Unretained(this)));
+ StartSamplingThread();
}
void V8SamplingProfiler::OnTraceLogDisabled() {
- task_runner_->PostTask(FROM_HERE,
- base::Bind(&V8SamplingProfiler::StopSamplingThread,
- base::Unretained(this)));
+ StopSamplingThread();
}
void V8SamplingProfiler::EnableSamplingEventForTesting(int code_added_events,
« no previous file with comments | « content/renderer/devtools/v8_sampling_profiler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698