| OLD | NEW |
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 1 // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" | 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" |
| 6 | 6 |
| 7 #include <stddef.h> | 7 #include <stddef.h> |
| 8 #include <algorithm> | 8 #include <algorithm> |
| 9 #include <string> | 9 #include <string> |
| 10 #include <utility> | 10 #include <utility> |
| (...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 78 link->set_id(id); | 78 link->set_id(id); |
| 79 return link; | 79 return link; |
| 80 } | 80 } |
| 81 | 81 |
| 82 views::Link* CreateLink(views::LinkListener* listener, | 82 views::Link* CreateLink(views::LinkListener* listener, |
| 83 int resource_id, | 83 int resource_id, |
| 84 int id) { | 84 int id) { |
| 85 return CreateLink(listener, l10n_util::GetStringUTF16(resource_id), id); | 85 return CreateLink(listener, l10n_util::GetStringUTF16(resource_id), id); |
| 86 } | 86 } |
| 87 | 87 |
| 88 // TODO(ftang) Restore icons in CreateViewAfterTranslate and CreateViewError |
| 89 // without causing layout issues; see http://crbug.com/610351 |
| 88 void AddIconToLayout(views::GridLayout* layout) { | 90 void AddIconToLayout(views::GridLayout* layout) { |
| 89 views::ImageView* icon = new views::ImageView(); | 91 views::ImageView* icon = new views::ImageView(); |
| 90 ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance(); | 92 ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance(); |
| 91 icon->SetImage(bundle.GetImageNamed(IDR_TRANSLATE_ICON_BUBBLE).ToImageSkia()); | 93 icon->SetImage(bundle.GetImageNamed(IDR_TRANSLATE_ICON_BUBBLE).ToImageSkia()); |
| 92 layout->AddView(icon); | 94 layout->AddView(icon); |
| 93 } | 95 } |
| 94 | 96 |
| 95 bool Use2016Q2UI() { | 97 bool Use2016Q2UI() { |
| 96 return base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2); | 98 return base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2); |
| 97 } | 99 } |
| (...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 696 view->SetLayoutManager(layout); | 698 view->SetLayoutManager(layout); |
| 697 | 699 |
| 698 using views::GridLayout; | 700 using views::GridLayout; |
| 699 | 701 |
| 700 enum { | 702 enum { |
| 701 COLUMN_SET_ID_MESSAGE, | 703 COLUMN_SET_ID_MESSAGE, |
| 702 COLUMN_SET_ID_CONTENT, | 704 COLUMN_SET_ID_CONTENT, |
| 703 }; | 705 }; |
| 704 | 706 |
| 705 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_MESSAGE); | 707 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_MESSAGE); |
| 706 if (Use2016Q2UI()) { | 708 |
| 707 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 709 // TODO(ftang) Restore icon without causing layout defects: crbug.com/610351 |
| 708 GridLayout::USE_PREF, 0, 0); | 710 |
| 709 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); | |
| 710 } | |
| 711 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 711 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, |
| 712 GridLayout::USE_PREF, 0, 0); | 712 GridLayout::USE_PREF, 0, 0); |
| 713 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); | 713 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); |
| 714 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 714 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, |
| 715 GridLayout::USE_PREF, 0, 0); | 715 GridLayout::USE_PREF, 0, 0); |
| 716 cs->AddPaddingColumn(1, 0); | 716 cs->AddPaddingColumn(1, 0); |
| 717 | 717 |
| 718 cs = layout->AddColumnSet(COLUMN_SET_ID_CONTENT); | 718 cs = layout->AddColumnSet(COLUMN_SET_ID_CONTENT); |
| 719 cs->AddPaddingColumn(1, 0); | 719 cs->AddPaddingColumn(1, 0); |
| 720 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 720 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, |
| 721 GridLayout::USE_PREF, 0, 0); | 721 GridLayout::USE_PREF, 0, 0); |
| 722 | 722 |
| 723 layout->StartRow(0, COLUMN_SET_ID_MESSAGE); | 723 layout->StartRow(0, COLUMN_SET_ID_MESSAGE); |
| 724 if (Use2016Q2UI()) | |
| 725 AddIconToLayout(layout); | |
| 726 layout->AddView(label); | 724 layout->AddView(label); |
| 727 layout->AddView( | 725 layout->AddView( |
| 728 CreateLink(this, IDS_TRANSLATE_BUBBLE_ADVANCED, LINK_ID_ADVANCED)); | 726 CreateLink(this, IDS_TRANSLATE_BUBBLE_ADVANCED, LINK_ID_ADVANCED)); |
| 729 | 727 |
| 730 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); | 728 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); |
| 731 | 729 |
| 732 layout->StartRow(0, COLUMN_SET_ID_CONTENT); | 730 layout->StartRow(0, COLUMN_SET_ID_CONTENT); |
| 733 layout->AddView(CreateLabelButton( | 731 layout->AddView(CreateLabelButton( |
| 734 this, l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_REVERT), | 732 this, l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_REVERT), |
| 735 BUTTON_ID_SHOW_ORIGINAL)); | 733 BUTTON_ID_SHOW_ORIGINAL)); |
| (...skipping 10 matching lines...) Expand all Loading... |
| 746 view->SetLayoutManager(layout); | 744 view->SetLayoutManager(layout); |
| 747 | 745 |
| 748 using views::GridLayout; | 746 using views::GridLayout; |
| 749 | 747 |
| 750 enum { | 748 enum { |
| 751 COLUMN_SET_ID_MESSAGE, | 749 COLUMN_SET_ID_MESSAGE, |
| 752 COLUMN_SET_ID_CONTENT, | 750 COLUMN_SET_ID_CONTENT, |
| 753 }; | 751 }; |
| 754 | 752 |
| 755 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_MESSAGE); | 753 views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_MESSAGE); |
| 756 if (Use2016Q2UI()) { | 754 |
| 757 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 755 // TODO(ftang) Restore icon without causing layout defects: crbug.com/610351 |
| 758 GridLayout::USE_PREF, 0, 0); | 756 |
| 759 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); | |
| 760 } | |
| 761 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 757 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, |
| 762 GridLayout::USE_PREF, 0, 0); | 758 GridLayout::USE_PREF, 0, 0); |
| 763 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); | 759 cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); |
| 764 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 760 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, |
| 765 GridLayout::USE_PREF, 0, 0); | 761 GridLayout::USE_PREF, 0, 0); |
| 766 cs->AddPaddingColumn(1, 0); | 762 cs->AddPaddingColumn(1, 0); |
| 767 | 763 |
| 768 cs = layout->AddColumnSet(COLUMN_SET_ID_CONTENT); | 764 cs = layout->AddColumnSet(COLUMN_SET_ID_CONTENT); |
| 769 cs->AddPaddingColumn(1, 0); | 765 cs->AddPaddingColumn(1, 0); |
| 770 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, | 766 cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0, |
| 771 GridLayout::USE_PREF, 0, 0); | 767 GridLayout::USE_PREF, 0, 0); |
| 772 | 768 |
| 773 layout->StartRow(0, COLUMN_SET_ID_MESSAGE); | 769 layout->StartRow(0, COLUMN_SET_ID_MESSAGE); |
| 774 if (Use2016Q2UI()) | |
| 775 AddIconToLayout(layout); | |
| 776 layout->AddView(label); | 770 layout->AddView(label); |
| 777 layout->AddView( | 771 layout->AddView( |
| 778 CreateLink(this, IDS_TRANSLATE_BUBBLE_ADVANCED, LINK_ID_ADVANCED)); | 772 CreateLink(this, IDS_TRANSLATE_BUBBLE_ADVANCED, LINK_ID_ADVANCED)); |
| 779 | 773 |
| 780 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); | 774 layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing); |
| 781 | 775 |
| 782 layout->StartRow(0, COLUMN_SET_ID_CONTENT); | 776 layout->StartRow(0, COLUMN_SET_ID_CONTENT); |
| 783 layout->AddView(CreateLabelButton( | 777 layout->AddView(CreateLabelButton( |
| 784 this, l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_TRY_AGAIN), | 778 this, l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_TRY_AGAIN), |
| 785 BUTTON_ID_TRY_AGAIN)); | 779 BUTTON_ID_TRY_AGAIN)); |
| (...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 936 advanced_done_button_->SizeToPreferredSize(); | 930 advanced_done_button_->SizeToPreferredSize(); |
| 937 if (advanced_view_) | 931 if (advanced_view_) |
| 938 advanced_view_->Layout(); | 932 advanced_view_->Layout(); |
| 939 } | 933 } |
| 940 | 934 |
| 941 void TranslateBubbleView::ReportUiAction( | 935 void TranslateBubbleView::ReportUiAction( |
| 942 translate::TranslateBubbleUiEvent action) { | 936 translate::TranslateBubbleUiEvent action) { |
| 943 UMA_HISTOGRAM_ENUMERATION(kTranslateBubbleUIEvent, action, | 937 UMA_HISTOGRAM_ENUMERATION(kTranslateBubbleUIEvent, action, |
| 944 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX); | 938 translate::TRANSLATE_BUBBLE_UI_EVENT_MAX); |
| 945 } | 939 } |
| OLD | NEW |