Temp fix for blank view. Somehow the third calls to AddIconToLayout() cause this strange bug. Tried…

chrome/browser/ui/views/translate/translate_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <string>
 #include <utility>
@@ skipping 67 matching lines @@
   link->set_id(id);
   return link;
 }
 
 views::Link* CreateLink(views::LinkListener* listener,
                         int resource_id,
                         int id) {
   return CreateLink(listener, l10n_util::GetStringUTF16(resource_id), id);
 }
 
+// Somehow the third views calling AddIconToLayout show blank as in

[msw, 2016/05/10 20:43:21]

This comment isn't very good. What does "third views" mean? Use the more common
'crbug.com' url, s/hook/hood/, who is 'we', and what do you mean by caching in
skia (caching what?) and what global variable did you try?

Instead, consider saying something like this:
// TODO(ftang) Restore icons in CreateViewAfterTranslate and CreateViewError 
// without causing layout issues; see http://crbug.com/610351

Or instead put two comments like this in the respective functions:
// TODO(ftang) Restore icon without causing layout defects: crbug.com/610351

[ftang, 2016/05/10 21:17:26]

Any third view (regardless which one) show the icon.
Somehow there are no problem for the first two views (regardless
which two) to show the icon but the third view (regardless which 
one) add the icon will cause it to become blank.

[ftang, 2016/05/10 21:17:26]

Done.

+// https://bugs.chromium.org/p/chromium/issues/detail?id=610351
+// We cannot figure out what is going on under the hook. Caching the Skia in
+// a global variable didn't help.
 void AddIconToLayout(views::GridLayout* layout) {
   views::ImageView* icon = new views::ImageView();
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   icon->SetImage(bundle.GetImageNamed(IDR_TRANSLATE_ICON_BUBBLE).ToImageSkia());
   layout->AddView(icon);
 }
 
 bool Use2016Q2UI() {
   return base::FeatureList::IsEnabled(translate::kTranslateUI2016Q2);
 }
@@ skipping 598 matching lines @@
   view->SetLayoutManager(layout);
 
   using views::GridLayout;
 
   enum {
     COLUMN_SET_ID_MESSAGE,
     COLUMN_SET_ID_CONTENT,
   };
 
   views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_MESSAGE);
-  if (Use2016Q2UI()) {
-    cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
-                  GridLayout::USE_PREF, 0, 0);
-    cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
-  }
   cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
                 GridLayout::USE_PREF, 0, 0);
   cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
   cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
                 GridLayout::USE_PREF, 0, 0);
   cs->AddPaddingColumn(1, 0);
 
   cs = layout->AddColumnSet(COLUMN_SET_ID_CONTENT);
   cs->AddPaddingColumn(1, 0);
   cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
                 GridLayout::USE_PREF, 0, 0);
 
   layout->StartRow(0, COLUMN_SET_ID_MESSAGE);
-  if (Use2016Q2UI())
-    AddIconToLayout(layout);
   layout->AddView(label);
   layout->AddView(
       CreateLink(this, IDS_TRANSLATE_BUBBLE_ADVANCED, LINK_ID_ADVANCED));
 
   layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
 
   layout->StartRow(0, COLUMN_SET_ID_CONTENT);
   layout->AddView(CreateLabelButton(
       this, l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_REVERT),
       BUTTON_ID_SHOW_ORIGINAL));
@@ skipping 10 matching lines @@
   view->SetLayoutManager(layout);
 
   using views::GridLayout;
 
   enum {
     COLUMN_SET_ID_MESSAGE,
     COLUMN_SET_ID_CONTENT,
   };
 
   views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_ID_MESSAGE);
-  if (Use2016Q2UI()) {
-    cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
-                  GridLayout::USE_PREF, 0, 0);
-    cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
-  }
   cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
                 GridLayout::USE_PREF, 0, 0);
   cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
   cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
                 GridLayout::USE_PREF, 0, 0);
   cs->AddPaddingColumn(1, 0);
 
   cs = layout->AddColumnSet(COLUMN_SET_ID_CONTENT);
   cs->AddPaddingColumn(1, 0);
   cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 0,
                 GridLayout::USE_PREF, 0, 0);
 
   layout->StartRow(0, COLUMN_SET_ID_MESSAGE);
-  if (Use2016Q2UI())
-    AddIconToLayout(layout);
   layout->AddView(label);
   layout->AddView(
       CreateLink(this, IDS_TRANSLATE_BUBBLE_ADVANCED, LINK_ID_ADVANCED));
 
   layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
 
   layout->StartRow(0, COLUMN_SET_ID_CONTENT);
   layout->AddView(CreateLabelButton(
       this, l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_TRY_AGAIN),
       BUTTON_ID_TRY_AGAIN));
@@ skipping 150 matching lines @@
   advanced_done_button_->SizeToPreferredSize();
   if (advanced_view_)
     advanced_view_->Layout();
 }
 
 void TranslateBubbleView::ReportUiAction(
     translate::TranslateBubbleUiEvent action) {
   UMA_HISTOGRAM_ENUMERATION(kTranslateBubbleUIEvent, action,
                             translate::TRANSLATE_BUBBLE_UI_EVENT_MAX);
 }