Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1967733003: Version 5.1.281.32 (cherry-pick) (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.32 (cherry-pick) Merged e17a283f92c99d4ba7daee0dbb2e7d9e65b91197 [es6] Properly handle the case when an inlined getter/setter/constructor does a tail call. BUG=chromium:608278, v8:4698 LOG=N R=jarin@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/b68332d0b5dd6e043daaeed6b7dc0f4761e72168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -333 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/lithium.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/crankshaft/lithium.cc View 2 chunks +51 lines, -1 line 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +1 line, -36 lines 0 comments Download
M src/deoptimizer.cc View 15 chunks +111 lines, -6 lines 0 comments Download
M test/mjsunit/es6/tail-call.js View 2 chunks +84 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-608278.js View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Igor Sheludko
4 years, 7 months ago (2016-05-11 08:02:48 UTC) #1
Jarin
lgtm (I see we like to live dangerously.)
4 years, 7 months ago (2016-05-11 08:18:11 UTC) #2
Igor Sheludko
4 years, 7 months ago (2016-05-11 08:24:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b68332d0b5dd6e043daaeed6b7dc0f4761e72168.

Powered by Google App Engine
This is Rietveld 408576698