Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1967733002: Break base/ dependency on WebAPKs. (Closed)

Created:
4 years, 7 months ago by Yaron
Modified:
4 years, 7 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, darin-cc_chromium.org, jam, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break base/ dependency on WebAPKs. Reintroduces the dependency in content/ but there's an implicit dep there anyway from the code in ChildProcessLauncher BUG=609122

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 2 chunks +1 line, -6 lines 3 comments Download
M content/public/android/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Yaron
4 years, 7 months ago (2016-05-10 19:39:50 UTC) #2
Xi Han
https://codereview.chromium.org/1967733002/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java (right): https://codereview.chromium.org/1967733002/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java#newcode290 base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:290: sLibraryPreloader.loadLibrary(context); If we always pass in the context of ...
4 years, 7 months ago (2016-05-11 13:47:22 UTC) #3
Yaron
https://codereview.chromium.org/1967733002/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java (right): https://codereview.chromium.org/1967733002/diff/1/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java#newcode290 base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:290: sLibraryPreloader.loadLibrary(context); On 2016/05/11 13:47:22, Xi Han wrote: > If ...
4 years, 7 months ago (2016-05-12 19:27:32 UTC) #4
Xi Han
4 years, 7 months ago (2016-05-12 19:30:57 UTC) #5 
lgtm

https://codereview.chromium.org/1967733002/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
(right):

https://codereview.chromium.org/1967733002/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:290:
sLibraryPreloader.loadLibrary(context);
On 2016/05/12 19:27:32, Yaron wrote:
> On 2016/05/11 13:47:22, Xi Han wrote:
> > If we always pass in the context of WebAPKs, will here be a problem when not
> > using linker?
> 
> Nope. If you use Chrome.apk it's actually using this path. ChromeModern.apk
uses
> the other. Both are fine. Logically to me this makes sense anyway, since the
> context for which we are loading apks

Got it.

Powered by Google App Engine
This is Rietveld 408576698