mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 1967703004: Mojo C++ bindings: add StringTraits and ArrayTraits for STL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 1967703004: Mojo C++ bindings: add StringTraits and ArrayTraits for STL types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@27_update_users

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index d3e23fe18bdd83807e9342819340332995578654..daac7802b642b046f2d97d816909f4b388f013dc 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -177,11 +177,7 @@ def GetCppPodType(kind):

def GetCppArrayArgWrapperType(kind):

if IsTypemappedKind(kind):

- if mojom.IsStructKind(kind) and kind.native_only:

- return GetNativeTypeName(kind)

- else:

- raise Exception(

- "Cannot serialize containers of non-native typemapped structs yet!")

+ return GetNativeTypeName(kind)

if mojom.IsEnumKind(kind):

return GetNameForKind(kind)

if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):

« no previous file with comments | « mojo/public/interfaces/bindings/tests/struct_with_traits.mojom ('k') | no next file » | no next file with comments »