mojo/public/interfaces/bindings/tests/struct_with_traits.mojom - Issue 1967703004: Mojo C++ bindings: add StringTraits and ArrayTraits for STL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

Issue 1967703004: Mojo C++ bindings: add StringTraits and ArrayTraits for STL types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@27_update_users

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

diff --git a/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom b/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

index f4ae0cecc90967b74c7c00e7472539f9623f2604..c8d1e660b1c4a02a44751844b37e342eb44d059a 100644

--- a/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

+++ b/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

@@ -4,12 +4,19 @@

module mojo.test;

+struct StructWithTraitsElement {

+ int32 value;

+};

struct StructWithTraits {

bool f_bool;

uint32 f_uint32;

uint64 f_uint64;

string f_string;

string f_string2;

+ array<string> f_array_string;

Ken Rockot(use gerrit already) 2016/05/13 14:35:51 nit: I think it would be clearer for readers if th

yzshen1 2016/05/13 16:01:17 Thanks! I changed to use NestedStructWithTraits,

+ StructWithTraitsElement f_element;

+ array<StructWithTraitsElement> f_array_element;

};

interface TraitsTestService {