Avoid object slicing in WebCredential::create

third_party/WebKit/Source/platform/exported/WebCredential.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "public/platform/WebCredential.h"
 
+#include "base/memory/ptr_util.h"
+
 #include "platform/credentialmanager/PlatformCredential.h"
 #include "public/platform/WebFederatedCredential.h"
 #include "public/platform/WebPasswordCredential.h"
 
 namespace blink {
 
-WebCredential WebCredential::create(PlatformCredential* credential)
+std::unique_ptr<WebCredential> WebCredential::create(PlatformCredential* credential)
 {
     if (credential->isPassword()) {
-        WebPasswordCredential password(credential);
-        return password;
+        return base::WrapUnique(new WebPasswordCredential(credential));

[haraken, 2016/05/11 14:16:11]

yutak@: We don't want to use base::WrapUnique, right?

std::unique_ptr(new WebPasswordCredential(credential));

[vabr (Chromium), 2016/05/11 14:42:58]

What about using wrapUnique from Source/wtf/PtrUtil.h, introduced in
https://codereview.chromium.org/1865913005?
That would avoid the type duplication in 
std::unique_ptr<X>(new X)

     }
 
     if (credential->isFederated()) {
-        WebFederatedCredential federated(credential);
-        return federated;
+        return base::WrapUnique(new WebFederatedCredential(credential));

[haraken, 2016/05/11 14:16:11]

Ditto.

     }
 
     ASSERT_NOT_REACHED();
-    return WebCredential(credential);
+    return nullptr;
 }
 
 WebCredential::WebCredential(const WebString& id, const WebString& name, const WebURL& iconURL)
     : m_platformCredential(PlatformCredential::create(id, name, iconURL))
 {
 }
 
 WebCredential::WebCredential(const WebCredential& other)
 {
     assign(other);
@@ skipping 44 matching lines @@
 {
     return m_platformCredential->isPassword();
 }
 
 bool WebCredential::isFederatedCredential() const
 {
     return m_platformCredential->isFederated();
 }
 
 } // namespace blink