[Mac][Material Design] Fix the new tab button's path.

[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to match the spec.
It also cleans up the appearance of the hover and pressed states.

R=avi@chromium.org
BUG=593535
Committed: https://crrev.com/6b20049f3e4405bbe7e7ca2e0184777bc1a331c2
Cr-Commit-Position: refs/heads/master@{#393172}

[shrike, 2016-05-11 23:47:16]

Description was changed from

==========
[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to be more in line
with the spec.

R=avi@chromium.org
BUG=593535
==========

to

==========
[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to match the spec.
It also cleans up the appearance of the hover and pressed states.

R=avi@chromium.org
BUG=593535
==========

[shrike, 2016-05-11 23:47:34]

PTAL

[Avi (use Gerrit), 2016-05-12 01:46:38]

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/new_tab_button.mm:27: const NSSize newTabButtonImageSize
= NSMakeSize(34, 18);
Is this a static initializer? NSMakeSize is a function that's not constexpr.

You may need to do = { 34, 18 }

[shrike, 2016-05-12 02:37:19]

PTAL

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/new_tab_button.mm:27: const NSSize newTabButtonImageSize
= NSMakeSize(34, 18);
On 2016/05/12 01:46:38, Avi wrote:
> Is this a static initializer? NSMakeSize is a function that's not constexpr.
> 
> You may need to do = { 34, 18 }

I thought NSMakeSize was a non-function macro.

[Avi (use Gerrit), 2016-05-12 02:46:09]

lgtm

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/new_tab_button.mm:27: const NSSize newTabButtonImageSize
= NSMakeSize(34, 18);
On 2016/05/12 02:37:19, shrike wrote:
> On 2016/05/12 01:46:38, Avi wrote:
> > Is this a static initializer? NSMakeSize is a function that's not constexpr.
> > 
> > You may need to do = { 34, 18 }
> 
> I thought NSMakeSize was a non-function macro.

In my 10.11 SDK's NSGeometry.h it has:

NS_INLINE NSPoint NSMakePoint(CGFloat x, CGFloat y) {
    NSPoint p;
    p.x = x;
    p.y = y;
    return p;
}

I had to double-check too; I didn't remember how they did it.

[shrike, 2016-05-12 02:50:00]

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

https://codereview.chromium.org/1967693002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/new_tab_button.mm:27: const NSSize newTabButtonImageSize
= NSMakeSize(34, 18);
On 2016/05/12 02:46:09, Avi wrote:
> On 2016/05/12 02:37:19, shrike wrote:
> > On 2016/05/12 01:46:38, Avi wrote:
> > > Is this a static initializer? NSMakeSize is a function that's not
constexpr.
> > > 
> > > You may need to do = { 34, 18 }
> > 
> > I thought NSMakeSize was a non-function macro.
> 
> In my 10.11 SDK's NSGeometry.h it has:
> 
> NS_INLINE NSPoint NSMakePoint(CGFloat x, CGFloat y) {
>     NSPoint p;
>     p.x = x;
>     p.y = y;
>     return p;
> }
> 
> I had to double-check too; I didn't remember how they did it.

Yeah, I checked after you pointed it out.

[shrike, 2016-05-12 02:50:08]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-12 02:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967693002/60001

[commit-bot: I haz the power, 2016-05-12 03:50:27]

Description was changed from

==========
[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to match the spec.
It also cleans up the appearance of the hover and pressed states.

R=avi@chromium.org
BUG=593535
==========

to

==========
[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to match the spec.
It also cleans up the appearance of the hover and pressed states.

R=avi@chromium.org
BUG=593535
==========

[commit-bot: I haz the power, 2016-05-12 03:50:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-12 03:51:37]

Description was changed from

==========
[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to match the spec.
It also cleans up the appearance of the hover and pressed states.

R=avi@chromium.org
BUG=593535
==========

to

==========
[Mac][Material Design] Fix the new tab button's path.

This cl refines the new tab button's vector path to match the spec.
It also cleans up the appearance of the hover and pressed states.

R=avi@chromium.org
BUG=593535

Committed: https://crrev.com/6b20049f3e4405bbe7e7ca2e0184777bc1a331c2
Cr-Commit-Position: refs/heads/master@{#393172}
==========

[commit-bot: I haz the power, 2016-05-12 03:51:38]

Patchset 4 (id:??) landed as
https://crrev.com/6b20049f3e4405bbe7e7ca2e0184777bc1a331c2
Cr-Commit-Position: refs/heads/master@{#393172}