Update toolchain packaging to support VC++ preview toolsets

Update toolchain packaging to support VC++ preview toolsets

This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:

https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compiler-toolset-without-waiting-for-the-next-update-of-visual-studio/

Typical usage is like this:

  package_from_installed.py 2015 --override <projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native

In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.

At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).

While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.

BUG=440500
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300527

[brucedawson, 2016-05-10 18:30:14]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[brucedawson, 2016-05-10 18:30:15]

Fixes, and support for testing pre-release compilers. PTAL.

I am currently testing a package created with this modified script.

[brucedawson, 2016-05-10 18:31:35]

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
File win_toolchain/package_from_installed.py (left):

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:161: if VS_VERSION == '2015':
This was embarrassing to find. Oops. I guess I wanted to be *really* sure that
VS 2015 was being packaged.

[scottmg, 2016-05-10 18:58:30]

lgtm

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
File win_toolchain/package_from_installed.py (right):

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:56: if (override_dir):
no ()

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:82:
('VC/redist/x86/Microsoft.VC140.CRT', 'sys32'),
None of these have subfolders that will be affected by the change in what tuples
mean, right?

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:329: parser.add_option('-o',
'--override', action='store', type='string',
-o makes me think "output", maybe a different letter, or no short?

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:344: sys.exit(0)
1, not 0, and return, not sys.exit().

[brucedawson, 2016-05-10 19:14:12]

Description was changed from

==========
Update toolchain packaging to support VC++ preview toolsets

This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:

https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compi...

Typical usage is like this:

  package_from_installed.py 2015 -o
<projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native

In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.

At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).

While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.

BUG=440500
==========

to

==========
Update toolchain packaging to support VC++ preview toolsets

This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:

https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compi...

Typical usage is like this:

  package_from_installed.py 2015 --override
<projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native

In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.

At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).

While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.

BUG=440500
==========

[brucedawson, 2016-05-10 19:24:05]

All comments addressed, and I double-checked that the new tuple handling doesn't
affect previously packaged files.

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
File win_toolchain/package_from_installed.py (right):

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:56: if (override_dir):
On 2016/05/10 18:58:30, scottmg wrote:
> no ()

D'oh! Too much switching between languages I guess. Weird. Done.

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:82:
('VC/redist/x86/Microsoft.VC140.CRT', 'sys32'),
On 2016/05/10 18:58:30, scottmg wrote:
> None of these have subfolders that will be affected by the change in what
tuples
> mean, right?

Correct. And I just triple-checked this by temporarily adding "assert dest == f"
after line 114 and verifying that it doesn't trigger when doing a dry-run with
no override, but does fire with the override.

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:329: parser.add_option('-o',
'--override', action='store', type='string',
On 2016/05/10 18:58:30, scottmg wrote:
> -o makes me think "output", maybe a different letter, or no short?

Yeah, agreed. No short it is. I'll update the description also.

https://codereview.chromium.org/1967653002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:344: sys.exit(0)
On 2016/05/10 18:58:30, scottmg wrote:
> 1, not 0, and return, not sys.exit().

Done.

[scottmg, 2016-05-10 19:26:38]

lgtm

[brucedawson, 2016-05-10 19:28:23]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-05-10 19:28:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967653002/20001

[commit-bot: I haz the power, 2016-05-10 19:33:09]

Description was changed from

==========
Update toolchain packaging to support VC++ preview toolsets

This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:

https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compi...

Typical usage is like this:

  package_from_installed.py 2015 --override
<projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native

In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.

At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).

While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.

BUG=440500
==========

to

==========
Update toolchain packaging to support VC++ preview toolsets

This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:

https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compi...

Typical usage is like this:

  package_from_installed.py 2015 --override
<projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native

In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.

At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).

While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.

BUG=440500

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300527
==========

[commit-bot: I haz the power, 2016-05-10 19:33:10]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300527