Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1967643002: IWYU: errno.h in third_party/webrtc_overrides (Closed)

Created:
4 years, 7 months ago by Mostyn Bramley-Moore
Modified:
4 years, 7 months ago
Reviewers:
Henrik Grunell, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IWYU: errno.h in third_party/webrtc_overrides Without this, some toolchains may fail to build third_party/webrtc/base/checks.cc because errno is undefined. BUG=468375 Committed: https://crrev.com/fc98dd23dfccebc60b34d817fc311859009cc24f Cr-Commit-Position: refs/heads/master@{#392677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/webrtc_overrides/webrtc/base/logging.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mostyn Bramley-Moore
@jam: Can you please take a look at this small fixup to https://codereview.chromium.org/1345873004 ? Without ...
4 years, 7 months ago (2016-05-10 17:48:45 UTC) #2
jam
On 2016/05/10 17:48:45, Mostyn Bramley-Moore wrote: > @jam: Can you please take a look at ...
4 years, 7 months ago (2016-05-10 18:09:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1967643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1967643002/1
4 years, 7 months ago (2016-05-10 18:11:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 19:24:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc98dd23dfccebc60b34d817fc311859009cc24f Cr-Commit-Position: refs/heads/master@{#392677}
4 years, 7 months ago (2016-05-10 19:25:43 UTC) #8
Henrik Grunell
4 years, 7 months ago (2016-05-11 08:13:43 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698