third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h - Issue 1967633002: Updated VRService to match the latest Blink WebVR interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

Issue 1967633002: Updated VRService to match the latest Blink WebVR interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: And we're back to removing all the array size checks Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/VREyeParameters.cpp ('k') | third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

diff --git a/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h b/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

index e7192b46baab3c4f4e7569c02029c75f4898ffb8..9cbe5575ece6c571cebf9071e9244ca02bc0e761 100644

--- a/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

+++ b/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

@@ -15,15 +15,15 @@ namespace blink {

class VRDisplayCollection;

class ScriptPromiseResolver;

-// Success and failure callbacks for getDevices.

-using WebVRGetDevicesCallback = WebCallbacks<mojo::WTFArray<mojom::blink::VRDeviceInfoPtr>, void>;

-class VRGetDevicesCallback final : public WebVRGetDevicesCallback {

+// Success and failure callbacks for getDisplays.

+using WebVRGetDisplaysCallback = WebCallbacks<mojo::WTFArray<mojom::blink::VRDisplayPtr>, void>;

+class VRGetDevicesCallback final : public WebVRGetDisplaysCallback {

USING_FAST_MALLOC(VRGetDevicesCallback);

public:

VRGetDevicesCallback(ScriptPromiseResolver*, VRDisplayCollection*);

~VRGetDevicesCallback() override;

- void onSuccess(mojo::WTFArray<mojom::blink::VRDeviceInfoPtr>) override;

+ void onSuccess(mojo::WTFArray<mojom::blink::VRDisplayPtr>) override;

void onError() override;

private: