third_party/WebKit/Source/modules/vr/VRStageParameters.cpp - Issue 1967633002: Updated VRService to match the latest Blink WebVR interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRStageParameters.cpp

Issue 1967633002: Updated VRService to match the latest Blink WebVR interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some fixes for Android and update the unit test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/vr/VRPose.cpp ('K') | « third_party/WebKit/Source/modules/vr/VRStageParameters.h ('k') | third_party/WebKit/public/platform/modules/vr/vr_service.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRStageParameters.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRStageParameters.cpp b/third_party/WebKit/Source/modules/vr/VRStageParameters.cpp

index 09ea2fd7a2dea1aebe2e8a119b862e557b7dc39e..3d549ce223e97c9befb77e157c1ba9c20672331c 100644

--- a/third_party/WebKit/Source/modules/vr/VRStageParameters.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRStageParameters.cpp

@@ -18,6 +18,13 @@ VRStageParameters::VRStageParameters()

m_standingTransform->data()[15] = 1.0f;

}

+void VRStageParameters::update(const mojom::blink::VRStageParametersPtr& stage)

+ m_standingTransform = DOMFloat32Array::create(&(stage->standingTransform.front()), 16);

+ m_sizeX = stage->sizeX;

+ m_sizeZ = stage->sizeZ;

DEFINE_TRACE(VRStageParameters)

{

visitor->trace(m_standingTransform);