Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: content/browser/vr/android/cardboard/cardboard_vr_device.cc

Issue 1967633002: Updated VRService to match the latest Blink WebVR interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: And we're back to removing all the array size checks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/vr/android/cardboard/cardboard_vr_device.h" 5 #include "content/browser/vr/android/cardboard/cardboard_vr_device.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 #include <algorithm> 8 #include <algorithm>
9 9
10 #include "base/android/context_utils.h" 10 #include "base/android/context_utils.h"
(...skipping 10 matching lines...) Expand all
21 21
22 using base::android::AttachCurrentThread; 22 using base::android::AttachCurrentThread;
23 23
24 namespace content { 24 namespace content {
25 25
26 bool CardboardVRDevice::RegisterCardboardVRDevice(JNIEnv* env) { 26 bool CardboardVRDevice::RegisterCardboardVRDevice(JNIEnv* env) {
27 return RegisterNativesImpl(env); 27 return RegisterNativesImpl(env);
28 } 28 }
29 29
30 CardboardVRDevice::CardboardVRDevice(VRDeviceProvider* provider) 30 CardboardVRDevice::CardboardVRDevice(VRDeviceProvider* provider)
31 : VRDevice(provider), frame_index_(0) { 31 : VRDevice(provider) {
32 JNIEnv* env = AttachCurrentThread(); 32 JNIEnv* env = AttachCurrentThread();
33 j_cardboard_device_.Reset(Java_CardboardVRDevice_create( 33 j_cardboard_device_.Reset(Java_CardboardVRDevice_create(
34 env, base::android::GetApplicationContext())); 34 env, base::android::GetApplicationContext()));
35 j_head_matrix_.Reset(env, env->NewFloatArray(16)); 35 j_head_matrix_.Reset(env, env->NewFloatArray(16));
36 } 36 }
37 37
38 CardboardVRDevice::~CardboardVRDevice() { 38 CardboardVRDevice::~CardboardVRDevice() {
39 Java_CardboardVRDevice_stopTracking(AttachCurrentThread(), 39 Java_CardboardVRDevice_stopTracking(AttachCurrentThread(),
40 j_cardboard_device_.obj()); 40 j_cardboard_device_.obj());
41 } 41 }
42 42
43 blink::mojom::VRDeviceInfoPtr CardboardVRDevice::GetVRDevice() { 43 blink::mojom::VRDisplayPtr CardboardVRDevice::GetVRDevice() {
44 TRACE_EVENT0("input", "CardboardVRDevice::GetVRDevice"); 44 TRACE_EVENT0("input", "CardboardVRDevice::GetVRDevice");
45 blink::mojom::VRDeviceInfoPtr device = blink::mojom::VRDeviceInfo::New(); 45 blink::mojom::VRDisplayPtr device = blink::mojom::VRDisplay::New();
46 46
47 JNIEnv* env = AttachCurrentThread(); 47 JNIEnv* env = AttachCurrentThread();
48 48
49 ScopedJavaLocalRef<jstring> j_device_name = 49 ScopedJavaLocalRef<jstring> j_device_name =
50 Java_CardboardVRDevice_getDeviceName(env, j_cardboard_device_.obj()); 50 Java_CardboardVRDevice_getDeviceName(env, j_cardboard_device_.obj());
51 device->deviceName = 51 device->displayName =
52 base::android::ConvertJavaStringToUTF8(env, j_device_name.obj()); 52 base::android::ConvertJavaStringToUTF8(env, j_device_name.obj());
53 53
54 ScopedJavaLocalRef<jfloatArray> j_fov(env, env->NewFloatArray(4)); 54 ScopedJavaLocalRef<jfloatArray> j_fov(env, env->NewFloatArray(4));
55 Java_CardboardVRDevice_getFieldOfView(env, j_cardboard_device_.obj(), 55 Java_CardboardVRDevice_getFieldOfView(env, j_cardboard_device_.obj(),
56 j_fov.obj()); 56 j_fov.obj());
57 57
58 std::vector<float> fov; 58 std::vector<float> fov;
59 base::android::JavaFloatArrayToFloatVector(env, j_fov.obj(), &fov); 59 base::android::JavaFloatArrayToFloatVector(env, j_fov.obj(), &fov);
60 60
61 device->hmdInfo = blink::mojom::VRHMDInfo::New(); 61 device->capabilities = blink::mojom::VRDisplayCapabilities::New();
62 blink::mojom::VRHMDInfoPtr& hmdInfo = device->hmdInfo; 62 device->capabilities->hasOrientation = true;
63 device->capabilities->hasPosition = false;
64 device->capabilities->hasExternalDisplay = false;
65 device->capabilities->canPresent = false;
63 66
64 hmdInfo->leftEye = blink::mojom::VREyeParameters::New(); 67 device->leftEye = blink::mojom::VREyeParameters::New();
65 hmdInfo->rightEye = blink::mojom::VREyeParameters::New(); 68 device->rightEye = blink::mojom::VREyeParameters::New();
66 blink::mojom::VREyeParametersPtr& left_eye = hmdInfo->leftEye; 69 blink::mojom::VREyeParametersPtr& left_eye = device->leftEye;
67 blink::mojom::VREyeParametersPtr& right_eye = hmdInfo->rightEye; 70 blink::mojom::VREyeParametersPtr& right_eye = device->rightEye;
68 71
69 left_eye->recommendedFieldOfView = blink::mojom::VRFieldOfView::New(); 72 left_eye->fieldOfView = blink::mojom::VRFieldOfView::New();
70 left_eye->recommendedFieldOfView->upDegrees = fov[0]; 73 left_eye->fieldOfView->upDegrees = fov[0];
71 left_eye->recommendedFieldOfView->downDegrees = fov[1]; 74 left_eye->fieldOfView->downDegrees = fov[1];
72 left_eye->recommendedFieldOfView->leftDegrees = fov[2]; 75 left_eye->fieldOfView->leftDegrees = fov[2];
73 left_eye->recommendedFieldOfView->rightDegrees = fov[3]; 76 left_eye->fieldOfView->rightDegrees = fov[3];
74 77
75 // Cardboard devices always assume a mirrored FOV, so this is just the left 78 // Cardboard devices always assume a mirrored FOV, so this is just the left
76 // eye FOV with the left and right degrees swapped. 79 // eye FOV with the left and right degrees swapped.
77 right_eye->recommendedFieldOfView = blink::mojom::VRFieldOfView::New(); 80 right_eye->fieldOfView = blink::mojom::VRFieldOfView::New();
78 right_eye->recommendedFieldOfView->upDegrees = fov[0]; 81 right_eye->fieldOfView->upDegrees = fov[0];
79 right_eye->recommendedFieldOfView->downDegrees = fov[1]; 82 right_eye->fieldOfView->downDegrees = fov[1];
80 right_eye->recommendedFieldOfView->leftDegrees = fov[3]; 83 right_eye->fieldOfView->leftDegrees = fov[3];
81 right_eye->recommendedFieldOfView->rightDegrees = fov[2]; 84 right_eye->fieldOfView->rightDegrees = fov[2];
82
83 // Cardboard does not support configurable FOV.
84 left_eye->maximumFieldOfView = left_eye->recommendedFieldOfView.Clone();
85 right_eye->maximumFieldOfView = right_eye->recommendedFieldOfView.Clone();
86 left_eye->minimumFieldOfView = left_eye->recommendedFieldOfView.Clone();
87 right_eye->minimumFieldOfView = right_eye->recommendedFieldOfView.Clone();
88 85
89 float ipd = Java_CardboardVRDevice_getIpd(env, j_cardboard_device_.obj()); 86 float ipd = Java_CardboardVRDevice_getIpd(env, j_cardboard_device_.obj());
90 87
91 left_eye->eyeTranslation = blink::mojom::VRVector3::New(); 88 left_eye->offset= mojo::Array<float>::New(3);
92 left_eye->eyeTranslation->x = ipd * -0.5f; 89 left_eye->offset[0] = ipd * -0.5f;
93 left_eye->eyeTranslation->y = 0.0f; 90 left_eye->offset[1] = 0.0f;
94 left_eye->eyeTranslation->z = 0.0f; 91 left_eye->offset[2] = 0.0f;
95 92
96 right_eye->eyeTranslation = blink::mojom::VRVector3::New(); 93 right_eye->offset = mojo::Array<float>::New(3);
97 right_eye->eyeTranslation->x = ipd * 0.5f; 94 right_eye->offset[0] = ipd * 0.5f;
98 right_eye->eyeTranslation->y = 0.0f; 95 right_eye->offset[1] = 0.0f;
99 right_eye->eyeTranslation->z = 0.0f; 96 right_eye->offset[2] = 0.0f;
100 97
101 ScopedJavaLocalRef<jintArray> j_screen_size(env, env->NewIntArray(2)); 98 ScopedJavaLocalRef<jintArray> j_screen_size(env, env->NewIntArray(2));
102 Java_CardboardVRDevice_getScreenSize(env, j_cardboard_device_.obj(), 99 Java_CardboardVRDevice_getScreenSize(env, j_cardboard_device_.obj(),
103 j_screen_size.obj()); 100 j_screen_size.obj());
104 101
105 std::vector<int> screen_size; 102 std::vector<int> screen_size;
106 base::android::JavaIntArrayToIntVector(env, j_screen_size.obj(), 103 base::android::JavaIntArrayToIntVector(env, j_screen_size.obj(),
107 &screen_size); 104 &screen_size);
108 105
109 left_eye->renderRect = blink::mojom::VRRect::New(); 106 left_eye->renderWidth = screen_size[0] / 2.0;
110 left_eye->renderRect->x = 0; 107 left_eye->renderHeight = screen_size[1];
111 left_eye->renderRect->y = 0;
112 left_eye->renderRect->width = screen_size[0] / 2.0;
113 left_eye->renderRect->height = screen_size[1];
114 108
115 right_eye->renderRect = blink::mojom::VRRect::New(); 109 right_eye->renderWidth = screen_size[0] / 2.0;
116 right_eye->renderRect->x = screen_size[0] / 2.0; 110 right_eye->renderHeight = screen_size[1];
117 right_eye->renderRect->y = 0;
118 right_eye->renderRect->width = screen_size[0] / 2.0;
119 right_eye->renderRect->height = screen_size[1];
120 111
121 return device; 112 return device;
122 } 113 }
123 114
124 blink::mojom::VRSensorStatePtr CardboardVRDevice::GetSensorState() { 115 blink::mojom::VRPosePtr CardboardVRDevice::GetPose() {
125 TRACE_EVENT0("input", "CardboardVRDevice::GetSensorState"); 116 TRACE_EVENT0("input", "CardboardVRDevice::GetSensorState");
126 blink::mojom::VRSensorStatePtr state = blink::mojom::VRSensorState::New(); 117 blink::mojom::VRPosePtr pose = blink::mojom::VRPose::New();
127 118
128 state->timestamp = base::Time::Now().ToJsTime(); 119 pose->timestamp = base::Time::Now().ToJsTime();
129 state->frameIndex = frame_index_++;
130 120
131 JNIEnv* env = AttachCurrentThread(); 121 JNIEnv* env = AttachCurrentThread();
132 Java_CardboardVRDevice_getSensorState(env, j_cardboard_device_.obj(), 122 Java_CardboardVRDevice_getSensorState(env, j_cardboard_device_.obj(),
133 j_head_matrix_.obj()); 123 j_head_matrix_.obj());
134 124
135 std::vector<float> head_matrix; 125 std::vector<float> head_matrix;
136 base::android::JavaFloatArrayToFloatVector(env, j_head_matrix_.obj(), 126 base::android::JavaFloatArrayToFloatVector(env, j_head_matrix_.obj(),
137 &head_matrix); 127 &head_matrix);
138 128
139 gfx::Transform transform( 129 gfx::Transform transform(
140 head_matrix[0], head_matrix[1], head_matrix[2], head_matrix[3], 130 head_matrix[0], head_matrix[1], head_matrix[2], head_matrix[3],
141 head_matrix[4], head_matrix[5], head_matrix[6], head_matrix[7], 131 head_matrix[4], head_matrix[5], head_matrix[6], head_matrix[7],
142 head_matrix[8], head_matrix[9], head_matrix[10], head_matrix[11], 132 head_matrix[8], head_matrix[9], head_matrix[10], head_matrix[11],
143 head_matrix[12], head_matrix[13], head_matrix[14], head_matrix[15]); 133 head_matrix[12], head_matrix[13], head_matrix[14], head_matrix[15]);
144 134
145 gfx::DecomposedTransform decomposed_transform; 135 gfx::DecomposedTransform decomposed_transform;
146 gfx::DecomposeTransform(&decomposed_transform, transform); 136 gfx::DecomposeTransform(&decomposed_transform, transform);
147 137
148 state->orientation = blink::mojom::VRVector4::New(); 138 pose->orientation = mojo::Array<float>::New(4);
149 state->orientation->x = decomposed_transform.quaternion[0]; 139 pose->orientation[0] = decomposed_transform.quaternion[0];
150 state->orientation->y = decomposed_transform.quaternion[1]; 140 pose->orientation[1] = decomposed_transform.quaternion[1];
151 state->orientation->z = decomposed_transform.quaternion[2]; 141 pose->orientation[2] = decomposed_transform.quaternion[2];
152 state->orientation->w = decomposed_transform.quaternion[3]; 142 pose->orientation[3] = decomposed_transform.quaternion[3];
153 143
154 state->position = blink::mojom::VRVector3::New(); 144 pose->position = mojo::Array<float>::New(3);
155 state->position->x = decomposed_transform.translate[0]; 145 pose->position[0] = decomposed_transform.translate[0];
156 state->position->y = decomposed_transform.translate[1]; 146 pose->position[1] = decomposed_transform.translate[1];
157 state->position->z = decomposed_transform.translate[2]; 147 pose->position[2] = decomposed_transform.translate[2];
158 148
159 return state; 149 return pose;
160 } 150 }
161 151
162 void CardboardVRDevice::ResetSensor() { 152 void CardboardVRDevice::ResetPose() {
163 Java_CardboardVRDevice_resetSensor(AttachCurrentThread(), 153 Java_CardboardVRDevice_resetSensor(AttachCurrentThread(),
164 j_cardboard_device_.obj()); 154 j_cardboard_device_.obj());
165 } 155 }
166 156
167 } // namespace content 157 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/vr/android/cardboard/cardboard_vr_device.h ('k') | content/browser/vr/test/fake_vr_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698